All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Mathieu Desnoyers
	<mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
Cc: Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [RFC PATCH 3/9] arm64: allocate sys_membarrier system call number
Date: Wed, 2 Sep 2015 11:10:50 +0100	[thread overview]
Message-ID: <20150902101049.GE25720@arm.com> (raw)
In-Reply-To: <1440698215-8355-4-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>

On Thu, Aug 27, 2015 at 06:56:49PM +0100, Mathieu Desnoyers wrote:
> arm64 sys_membarrier number is already wired for arm64 through
> asm-generic/unistd.h, but needs to be allocated separately for
> the 32-bit compability layer of arm64.
> 
> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>   apply this patch, build/run a membarrier-enabled kernel, and do make
>   kselftest. ]
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
> CC: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> CC: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> CC: Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>
> CC: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> ---
>  arch/arm64/include/asm/unistd32.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index cef934a..d97be80 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -797,3 +797,5 @@ __SYSCALL(__NR_memfd_create, sys_memfd_create)
>  __SYSCALL(__NR_bpf, sys_bpf)
>  #define __NR_execveat 387
>  __SYSCALL(__NR_execveat, compat_sys_execveat)
> +#define __NR_membarrier 388
> +__SYSCALL(__NR_membarrier, sys_membarrier)

I think people have made similar comments for other architectures, but
please also updated __NR_compat_syscalls when adding new compat syscalls
here.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [RFC PATCH 3/9] arm64: allocate sys_membarrier system call number
Date: Wed, 2 Sep 2015 11:10:50 +0100	[thread overview]
Message-ID: <20150902101049.GE25720@arm.com> (raw)
In-Reply-To: <1440698215-8355-4-git-send-email-mathieu.desnoyers@efficios.com>

On Thu, Aug 27, 2015 at 06:56:49PM +0100, Mathieu Desnoyers wrote:
> arm64 sys_membarrier number is already wired for arm64 through
> asm-generic/unistd.h, but needs to be allocated separately for
> the 32-bit compability layer of arm64.
> 
> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>   apply this patch, build/run a membarrier-enabled kernel, and do make
>   kselftest. ]
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: linux-api@vger.kernel.org
> CC: Catalin Marinas <catalin.marinas@arm.com>
> CC: Will Deacon <will.deacon@arm.com>
> ---
>  arch/arm64/include/asm/unistd32.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index cef934a..d97be80 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -797,3 +797,5 @@ __SYSCALL(__NR_memfd_create, sys_memfd_create)
>  __SYSCALL(__NR_bpf, sys_bpf)
>  #define __NR_execveat 387
>  __SYSCALL(__NR_execveat, compat_sys_execveat)
> +#define __NR_membarrier 388
> +__SYSCALL(__NR_membarrier, sys_membarrier)

I think people have made similar comments for other architectures, but
please also updated __NR_compat_syscalls when adding new compat syscalls
here.

Will

  parent reply	other threads:[~2015-09-02 10:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 17:56 [RFC PATCH 0/9] allocate sys_membarrier system call number on major archs Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 1/9] powerpc: allocate sys_membarrier system call number Mathieu Desnoyers
2015-08-31  6:54   ` Michael Ellerman
2015-08-31 15:32     ` Mathieu Desnoyers
     [not found]       ` <131898944.32688.1441035174419.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-09-01  1:00         ` Michael Ellerman
2015-09-01  1:00           ` Michael Ellerman
     [not found] ` <1440698215-8355-1-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-08-27 17:56   ` [RFC PATCH 2/9] arm: " Mathieu Desnoyers
2015-08-27 17:56     ` Mathieu Desnoyers
2015-08-27 22:51     ` Russell King - ARM Linux
     [not found]       ` <20150827225147.GG21084-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-08-27 23:16         ` Mathieu Desnoyers
2015-08-27 23:16           ` Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 3/9] arm64: " Mathieu Desnoyers
     [not found]   ` <1440698215-8355-4-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-09-02 10:10     ` Will Deacon [this message]
2015-09-02 10:10       ` Will Deacon
     [not found]       ` <20150902101049.GE25720-5wv7dgnIgG8@public.gmane.org>
2015-09-03 15:38         ` Mathieu Desnoyers
2015-09-03 15:38           ` Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 4/9] mips: " Mathieu Desnoyers
     [not found]   ` <1440698215-8355-5-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-08-28  7:40     ` Ralf Baechle
2015-08-28  7:40       ` Ralf Baechle
     [not found]       ` <20150828074034.GA22604-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2015-08-28 14:06         ` Mathieu Desnoyers
2015-08-28 14:06           ` Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 5/9] s390/s390x: " Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 6/9] sparc/sparc64: " Mathieu Desnoyers
2015-08-27 17:56   ` Mathieu Desnoyers
     [not found]   ` <1440698215-8355-7-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-08-27 23:16     ` David Miller
2015-08-27 23:16       ` David Miller
2015-08-27 23:16       ` David Miller
2015-08-27 17:56 ` [RFC PATCH 7/9] alpha: " Mathieu Desnoyers
2015-08-27 18:34   ` Matt Turner
     [not found]     ` <CAEdQ38HvhvcbmV_zCi=hHBnx7OnuHgX_SvvhEFjs+-hYYaDa_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-27 19:06       ` Mathieu Desnoyers
2015-08-27 19:06         ` Mathieu Desnoyers
2015-08-27 19:07     ` [RFC PATCH v2] " Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 8/9] ia64: " Mathieu Desnoyers
2015-08-27 17:56   ` Mathieu Desnoyers
2015-08-27 17:56 ` [RFC PATCH 9/9] parisc: " Mathieu Desnoyers
     [not found]   ` <1440698215-8355-10-git-send-email-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-09-03 12:26     ` Helge Deller
2015-09-03 12:26       ` Helge Deller
2015-09-03 15:41       ` Mathieu Desnoyers
2015-09-03 15:41         ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150902101049.GE25720@arm.com \
    --to=will.deacon-5wv7dgnigg8@public.gmane.org \
    --cc=Catalin.Marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.