From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
ohn David Anglin <dave.anglin@bell.net>
Subject: [PATCH] parisc: Align locks for LWS syscalls to L1 cache size
Date: Wed, 2 Sep 2015 21:38:40 +0200 [thread overview]
Message-ID: <20150902193840.GA4499@ls3530.box> (raw)
Align the locks for the Light weight syscall (LWS) which is used for
atomic userspace operations (e.g. gcc atomic builtins) on L1 cache
boundaries. This should speed up LWS calls on PA20 systems.
Reported-by: John David Anglin <dave.anglin@bell.net>
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S
index 7ef22e3..80c2306 100644
--- a/arch/parisc/kernel/syscall.S
+++ b/arch/parisc/kernel/syscall.S
@@ -561,9 +561,9 @@ lws_compare_and_swap:
extru %r26, 27, 4, %r20
/* Find lock to use, the hash is either one of 0 to
- 15, multiplied by 16 (keep it 16-byte aligned)
+ 15, multiplied by L1_CACHE_BYTES (keep it L1 cache aligned)
and add to the lock table offset. */
- shlw %r20, 4, %r20
+ shlw %r20, L1_CACHE_SHIFT, %r20
add %r20, %r28, %r20
# if ENABLE_LWS_DEBUG
@@ -751,9 +751,9 @@ cas2_lock_start:
extru %r26, 27, 4, %r20
/* Find lock to use, the hash is either one of 0 to
- 15, multiplied by 16 (keep it 16-byte aligned)
+ 15, multiplied by L1_CACHE_BYTES (keep it L1 cache aligned)
and add to the lock table offset. */
- shlw %r20, 4, %r20
+ shlw %r20, L1_CACHE_SHIFT, %r20
add %r20, %r28, %r20
rsm PSW_SM_I, %r0 /* Disable interrupts */
@@ -931,11 +931,9 @@ END(sys_call_table64)
ENTRY(lws_lock_start)
/* lws locks */
.rept 16
- /* Keep locks aligned at 16-bytes */
+ /* Keep locks aligned to L1_CACHE_BYTES */
.word 1
- .word 0
- .word 0
- .word 0
+ .align L1_CACHE_BYTES
.endr
END(lws_lock_start)
.previous
next reply other threads:[~2015-09-02 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 19:38 Helge Deller [this message]
2015-09-02 19:46 ` [PATCH] parisc: Align locks for LWS syscalls to L1 cache size John David Anglin
2015-09-02 20:29 ` Helge Deller
2015-09-05 21:48 ` Helge Deller
2015-09-07 20:51 ` Helge Deller
2015-09-02 21:32 ` James Bottomley
2015-09-02 22:18 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902193840.GA4499@ls3530.box \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.