Re: [PATCH v2 0/9] Add DSP topology management for SKL

[Vinod Koul <vinod.koul@intel.com>]

On Mon, Aug 17, 2015 at 10:56:35PM +0530, Vinod Koul wrote:
> The SKL driver does not code DSP topology in driver. With this series
> the ASoC topology framework is used to parse the topology information
> to create widgets, controls and route map for the FW topology.
> 
> It adds routines for SKL DSP module configuration, compute resources
> for modules, initialize and bind the pipe modules. It uses the SKL IPC
> library added earlier to send IPC for initialize the module, bind/unbind
> modules.
> Last patch in this series removes the unused dais.

Hi Mark,

I was wondering if you have any feedback on this series ?

Thanks

-- 
~Vinod

> 
> changes in v2:
> - add more explanation in changelog and code
> - add explanation of MCPS
> - fix whitespace issues
> - remove skl widget check on event handler as it is redundant
> - add switch for depth
> - add else for direction based code
> - remove cast for NHLT blob query
> - make debug prints to error
> - remove dump info
> - clean some debug prints
> 
> Jeeja KP (9):
>   ASoC: Intel: Skylake: Add pipe and modules handlers
>   ASoC: Intel: Skylake: Add module configuration helpers
>   ASoC: Intel: Skylake: add DSP platform widget event handlers
>   ASoC: Intel: Skylake: Add FE and BE hw_params handling
>   ASoC: Intel: Skylake: Add topology core init and handlers
>   ASoC: Intel: Skylake: Initialize and load DSP controls
>   ASoC: Intel: Skylake: Add DSP support and enable it
>   ASoC: Intel: Skylake: Initialize NHLT table
>   ASoC: Intel: Skylake: Remove unused CPU dai's
> 
>  sound/soc/intel/skylake/Makefile             |    3 +-
>  sound/soc/intel/skylake/skl-pcm.c            |  171 ++--
>  sound/soc/intel/skylake/skl-topology.c       | 1262 ++++++++++++++++++++++++++
>  sound/soc/intel/skylake/skl-topology.h       |   21 +
>  sound/soc/intel/skylake/skl-tplg-interface.h |   78 ++
>  sound/soc/intel/skylake/skl.c                |   29 +-
>  sound/soc/intel/skylake/skl.h                |   11 +
>  7 files changed, 1507 insertions(+), 68 deletions(-)
>  create mode 100644 sound/soc/intel/skylake/skl-topology.c
> 
> -- 
> 1.9.1
>