Re: [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF

[Darren Hart <dvhart@infradead.org>]

On Wed, Sep 02, 2015 at 04:10:34PM -0600, Daniel Drake wrote:
> These laptops boot with wifi as hard-blocked, with no obvious way to
> enable it. Using a quirk to set wapf=4 solves the problem.
> 
> Signed-off-by: Daniel Drake <drake@endlessm.com>

Looks good.

Corentin, any concerns?

> ---
>  drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index abdaed3..131fee2 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = {
>  	},
>  	{
>  		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X456UA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"),
> +		},
> +		.driver_data = &quirk_asus_wapf4,
> +	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X456UF",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"),
> +		},
> +		.driver_data = &quirk_asus_wapf4,
> +	},
> +	{
> +		.callback = dmi_matched,
>  		.ident = "ASUSTeK COMPUTER INC. X501U",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> -- 
> 2.1.4
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center