* [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF
@ 2015-09-02 22:10 Daniel Drake
2015-09-03 22:54 ` Darren Hart
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Drake @ 2015-09-02 22:10 UTC (permalink / raw)
To: corentin.chary, dvhart
Cc: acelan.kao, carlo, acpi4asus-user, platform-driver-x86
These laptops boot with wifi as hard-blocked, with no obvious way to
enable it. Using a quirk to set wapf=4 solves the problem.
Signed-off-by: Daniel Drake <drake@endlessm.com>
---
drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index abdaed3..131fee2 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = {
},
{
.callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. X456UA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"),
+ },
+ .driver_data = &quirk_asus_wapf4,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. X456UF",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"),
+ },
+ .driver_data = &quirk_asus_wapf4,
+ },
+ {
+ .callback = dmi_matched,
.ident = "ASUSTeK COMPUTER INC. X501U",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF
2015-09-02 22:10 [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF Daniel Drake
@ 2015-09-03 22:54 ` Darren Hart
2015-09-06 8:40 ` Corentin Chary
0 siblings, 1 reply; 6+ messages in thread
From: Darren Hart @ 2015-09-03 22:54 UTC (permalink / raw)
To: Daniel Drake
Cc: corentin.chary, acelan.kao, carlo, acpi4asus-user,
platform-driver-x86
On Wed, Sep 02, 2015 at 04:10:34PM -0600, Daniel Drake wrote:
> These laptops boot with wifi as hard-blocked, with no obvious way to
> enable it. Using a quirk to set wapf=4 solves the problem.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
Looks good.
Corentin, any concerns?
> ---
> drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index abdaed3..131fee2 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = {
> },
> {
> .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X456UA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X456UF",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,
> .ident = "ASUSTeK COMPUTER INC. X501U",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> --
> 2.1.4
>
>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF
2015-09-03 22:54 ` Darren Hart
@ 2015-09-06 8:40 ` Corentin Chary
2015-09-06 17:45 ` Darren Hart
2015-09-07 13:55 ` Daniel Drake
0 siblings, 2 replies; 6+ messages in thread
From: Corentin Chary @ 2015-09-06 8:40 UTC (permalink / raw)
To: Darren Hart
Cc: Daniel Drake, AceLan Kao, carlo, acpi4asus-user,
platform-driver-x86@vger.kernel.org
Looks good.
Acked-by: Corentin Chary <corentin.chary@gmail.com>
I'd like to get somebody from Asus help us guess these values instead
of just hard-coding them.. Unfortunately I have no contact with them
anymore.
On Fri, Sep 4, 2015 at 12:54 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Wed, Sep 02, 2015 at 04:10:34PM -0600, Daniel Drake wrote:
>> These laptops boot with wifi as hard-blocked, with no obvious way to
>> enable it. Using a quirk to set wapf=4 solves the problem.
>>
>> Signed-off-by: Daniel Drake <drake@endlessm.com>
>
> Looks good.
>
> Corentin, any concerns?
>
>> ---
>> drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index abdaed3..131fee2 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = {
>> },
>> {
>> .callback = dmi_matched,
>> + .ident = "ASUSTeK COMPUTER INC. X456UA",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"),
>> + },
>> + .driver_data = &quirk_asus_wapf4,
>> + },
>> + {
>> + .callback = dmi_matched,
>> + .ident = "ASUSTeK COMPUTER INC. X456UF",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"),
>> + },
>> + .driver_data = &quirk_asus_wapf4,
>> + },
>> + {
>> + .callback = dmi_matched,
>> .ident = "ASUSTeK COMPUTER INC. X501U",
>> .matches = {
>> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> --
>> 2.1.4
>>
>>
>
> --
> Darren Hart
> Intel Open Source Technology Center
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF
2015-09-06 8:40 ` Corentin Chary
@ 2015-09-06 17:45 ` Darren Hart
2015-09-07 13:55 ` Daniel Drake
1 sibling, 0 replies; 6+ messages in thread
From: Darren Hart @ 2015-09-06 17:45 UTC (permalink / raw)
To: Corentin Chary
Cc: Daniel Drake, AceLan Kao, carlo, acpi4asus-user,
platform-driver-x86@vger.kernel.org
On Sun, Sep 06, 2015 at 10:40:05AM +0200, Corentin Chary wrote:
> Looks good.
>
> Acked-by: Corentin Chary <corentin.chary@gmail.com>
Thanks, queued for testing. Should make 4.3.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF
2015-09-06 8:40 ` Corentin Chary
2015-09-06 17:45 ` Darren Hart
@ 2015-09-07 13:55 ` Daniel Drake
2015-09-08 9:28 ` Corentin Chary
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Drake @ 2015-09-07 13:55 UTC (permalink / raw)
To: Corentin Chary
Cc: Darren Hart, AceLan Kao, Carlo Caione, acpi4asus-user,
platform-driver-x86@vger.kernel.org
On Sun, Sep 6, 2015 at 2:40 AM, Corentin Chary <corentin.chary@gmail.com> wrote:
> Looks good.
>
> Acked-by: Corentin Chary <corentin.chary@gmail.com>
>
> I'd like to get somebody from Asus help us guess these values instead
> of just hard-coding them.. Unfortunately I have no contact with them
> anymore.
I'll see if I can get a conversation going. I don't fully grasp this
WAPF situation though. Are you hoping that they would provide us with
a complete list of laptops to quirk, or do you think there is instead
some way we could improve the code to work with all models without a
specific whitelist/blacklist?
Thanks
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF
2015-09-07 13:55 ` Daniel Drake
@ 2015-09-08 9:28 ` Corentin Chary
0 siblings, 0 replies; 6+ messages in thread
From: Corentin Chary @ 2015-09-08 9:28 UTC (permalink / raw)
To: Daniel Drake
Cc: Darren Hart, AceLan Kao, Carlo Caione, acpi4asus-user,
platform-driver-x86@vger.kernel.org
On Mon, Sep 7, 2015 at 3:55 PM, Daniel Drake <drake@endlessm.com> wrote:
> On Sun, Sep 6, 2015 at 2:40 AM, Corentin Chary <corentin.chary@gmail.com> wrote:
>> Looks good.
>>
>> Acked-by: Corentin Chary <corentin.chary@gmail.com>
>>
>> I'd like to get somebody from Asus help us guess these values instead
>> of just hard-coding them.. Unfortunately I have no contact with them
>> anymore.
>
> I'll see if I can get a conversation going. I don't fully grasp this
> WAPF situation though. Are you hoping that they would provide us with
> a complete list of laptops to quirk, or do you think there is instead
> some way we could improve the code to work with all models without a
> specific whitelist/blacklist?
I think at least having proper documentation of the intended behavior
of WAPF and how they themselves set the value for windows would be
great.
> Thanks
> Daniel
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-08 9:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02 22:10 [PATCH] asus-nb-wmi: Add wapf=4 quirk for X456UA/X456UF Daniel Drake
2015-09-03 22:54 ` Darren Hart
2015-09-06 8:40 ` Corentin Chary
2015-09-06 17:45 ` Darren Hart
2015-09-07 13:55 ` Daniel Drake
2015-09-08 9:28 ` Corentin Chary
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.