From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 8/9] perf, tools, stat: Remove extra unsupported/not counted handling
Date: Fri, 4 Sep 2015 10:51:16 +0200 [thread overview]
Message-ID: <20150904085116.GD12338@krava.redhat.com> (raw)
In-Reply-To: <1441236954-24886-9-git-send-email-andi@firstfloor.org>
On Wed, Sep 02, 2015 at 04:35:53PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> printout now handles unsupported/not counted printing, so we can
> remove one extra instance in the aggregated printing.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/builtin-stat.c | 22 ++--------------------
> 1 file changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index f049fa67c..68c16e6 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -841,26 +841,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
> if (prefix)
> fprintf(output, "%s", prefix);
>
> - if (scaled == -1 || !counter->supported) {
> - fprintf(output, "%*s%s",
> - csv_output ? 0 : 18,
> - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> - csv_sep);
> - fprintf(output, "%-*s%s",
> - csv_output ? 0 : unit_width,
> - counter->unit, csv_sep);
> - fprintf(output, "%*s",
> - csv_output ? 0 : -25,
> - perf_evsel__name(counter));
> -
> - if (counter->cgrp)
> - fprintf(output, "%s%s", csv_sep, counter->cgrp->name);
> -
> - print_running(avg_running, avg_enabled);
> - fputc('\n', output);
> - return;
> - }
why is this not part of the:
perf, tools, stat: Move non counting counter printing to printout
jirka
next prev parent reply other threads:[~2015-09-04 8:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 23:35 perf, tools: Refactor and support interval and CSV metrics v3 Andi Kleen
2015-09-02 23:35 ` [PATCH 1/9] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-09-04 8:25 ` Jiri Olsa
2015-09-02 23:35 ` [PATCH 2/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-09-04 8:46 ` Jiri Olsa
2015-09-04 9:00 ` Jiri Olsa
2015-09-02 23:35 ` [PATCH 3/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-09-02 23:35 ` [PATCH 4/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-09-02 23:35 ` [PATCH 5/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-09-02 23:35 ` [PATCH 6/9] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
2015-09-02 23:35 ` [PATCH 7/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2015-09-02 23:35 ` [PATCH 8/9] perf, tools, stat: Remove extra unsupported/not counted handling Andi Kleen
2015-09-04 8:50 ` Jiri Olsa
2015-09-04 8:51 ` Jiri Olsa [this message]
2015-09-02 23:35 ` [PATCH 9/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2015-09-03 13:17 ` perf, tools: Refactor and support interval and CSV metrics v3 Jiri Olsa
2015-09-03 13:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904085116.GD12338@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.