From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/9] perf, tools, stat: Abstract stat metrics printing
Date: Fri, 4 Sep 2015 11:00:30 +0200 [thread overview]
Message-ID: <20150904090030.GE12338@krava.redhat.com> (raw)
In-Reply-To: <1441236954-24886-3-git-send-email-andi@firstfloor.org>
On Wed, Sep 02, 2015 at 04:35:47PM -0700, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
> index 62448c8..bb07e46 100644
> --- a/tools/perf/util/stat.h
> +++ b/tools/perf/util/stat.h
> @@ -67,11 +67,21 @@ void perf_stat_evsel_id_init(struct perf_evsel *evsel);
>
> extern struct stats walltime_nsecs_stats;
>
> +typedef void (*print_metric_t)(void *ctx, const char *color, const char *unit,
> + const char *fmt, double val);
> +
> void perf_stat__reset_shadow_stats(void);
> void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 *count,
> int cpu);
> -void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel,
> - double avg, int cpu, enum aggr_mode aggr);
> +struct perf_stat_output_ctx {
> + void *ctx;
> + print_metric_t print_metric;
> + void (*new_line)(void *ctx);
please add typedef for new_line as well
jirka
next prev parent reply other threads:[~2015-09-04 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 23:35 perf, tools: Refactor and support interval and CSV metrics v3 Andi Kleen
2015-09-02 23:35 ` [PATCH 1/9] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-09-04 8:25 ` Jiri Olsa
2015-09-02 23:35 ` [PATCH 2/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-09-04 8:46 ` Jiri Olsa
2015-09-04 9:00 ` Jiri Olsa [this message]
2015-09-02 23:35 ` [PATCH 3/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-09-02 23:35 ` [PATCH 4/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-09-02 23:35 ` [PATCH 5/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-09-02 23:35 ` [PATCH 6/9] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
2015-09-02 23:35 ` [PATCH 7/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2015-09-02 23:35 ` [PATCH 8/9] perf, tools, stat: Remove extra unsupported/not counted handling Andi Kleen
2015-09-04 8:50 ` Jiri Olsa
2015-09-04 8:51 ` Jiri Olsa
2015-09-02 23:35 ` [PATCH 9/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2015-09-03 13:17 ` perf, tools: Refactor and support interval and CSV metrics v3 Jiri Olsa
2015-09-03 13:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904090030.GE12338@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.