* [PATCH] staging: emxx_udc: Remove cleanup1 label
@ 2015-09-04 19:38 Ravi Teja Darbha
0 siblings, 0 replies; only message in thread
From: Ravi Teja Darbha @ 2015-09-04 19:38 UTC (permalink / raw)
To: gregkh
Cc: hamohammed.sa, vinc94, balbi, roberta.dobrescu, tapaswenipathak,
hgujulan, devel, linux-kernel
The cleanup1 label does nothing but return. Better way is to return
immediately instead of using goto. Hence, removed.
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 8cef08d..ffb8a3d 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -3284,14 +3284,14 @@ static int nbu2ss_drv_probe(struct platform_device *pdev)
/* USB Function Controller Interrupt */
if (status != 0) {
dev_err(udc->dev, "request_irq(USB_UDC_IRQ_1) failed\n");
- goto cleanup1;
+ return status;
}
/* Driver Initialization */
status = nbu2ss_drv_contest_init(pdev, udc);
if (status < 0) {
/* Error */
- goto cleanup1;
+ return status;
}
/* VBUS Interrupt */
@@ -3304,13 +3304,10 @@ static int nbu2ss_drv_probe(struct platform_device *pdev)
if (status != 0) {
dev_err(udc->dev, "request_irq(INT_VBUS) failed\n");
- goto cleanup1;
+ return status;
}
return status;
-
-cleanup1:
- return status;
}
/*-------------------------------------------------------------------------*/
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-04 19:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-04 19:38 [PATCH] staging: emxx_udc: Remove cleanup1 label Ravi Teja Darbha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.