From: Shawn Guo <shawnguo@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
sboyd@codeaurora.org, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, nm@ti.com, Pavel Machek <pavel@ucw.cz>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>, Len Brown <len.brown@intel.com>,
"moderated list:ARM SUB-ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH V3 2/6] PM / OPP: Rename opp init/free table routines
Date: Sun, 6 Sep 2015 20:26:06 +0800 [thread overview]
Message-ID: <20150906122606.GT30746@tiger> (raw)
In-Reply-To: <6bdbc2c69b18528648d5a752da0d6176825bd870.1441354424.git.viresh.kumar@linaro.org>
On Fri, Sep 04, 2015 at 01:47:23PM +0530, Viresh Kumar wrote:
> free-table routines are opposite of init-table ones, and must be named
> to make that clear. Opposite of 'init' is 'exit', but those doesn't suit
> really well.
>
> Replace 'init' with 'add' and 'free' with 'remove'.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm/mach-imx/mach-imx6q.c | 2 +-
...
> drivers/cpufreq/imx6q-cpufreq.c | 6 +++---
Acked-by: Shawn Guo <shawnguo@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/6] PM / OPP: Rename opp init/free table routines
Date: Sun, 6 Sep 2015 20:26:06 +0800 [thread overview]
Message-ID: <20150906122606.GT30746@tiger> (raw)
In-Reply-To: <6bdbc2c69b18528648d5a752da0d6176825bd870.1441354424.git.viresh.kumar@linaro.org>
On Fri, Sep 04, 2015 at 01:47:23PM +0530, Viresh Kumar wrote:
> free-table routines are opposite of init-table ones, and must be named
> to make that clear. Opposite of 'init' is 'exit', but those doesn't suit
> really well.
>
> Replace 'init' with 'add' and 'free' with 'remove'.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm/mach-imx/mach-imx6q.c | 2 +-
...
> drivers/cpufreq/imx6q-cpufreq.c | 6 +++---
Acked-by: Shawn Guo <shawnguo@kernel.org>
next prev parent reply other threads:[~2015-09-06 12:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 8:17 [PATCH V3 0/6] PM / OPP: Add debugfs support Viresh Kumar
2015-09-04 8:17 ` [PATCH V3 1/6] PM / OPP: reuse of_parse_phandle() Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-04 8:17 ` [PATCH V3 2/6] PM / OPP: Rename opp init/free table routines Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-06 12:26 ` Shawn Guo [this message]
2015-09-06 12:26 ` Shawn Guo
2015-09-04 8:17 ` [PATCH V3 3/6] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-06 12:27 ` Shawn Guo
2015-09-06 12:27 ` Shawn Guo
2015-09-04 8:17 ` [PATCH V3 4/6] PM / OPP: Move opp core to its own directory Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-04 8:17 ` [PATCH V3 5/6] PM / OPP: Move cpu specific code to opp/cpu.c Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
2015-09-04 8:17 ` [PATCH V3 6/6] PM / OPP: Add debugfs support Viresh Kumar
2015-09-04 8:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906122606.GT30746@tiger \
--to=shawnguo@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.