From: Mark Rutland <mark.rutland@arm.com>
To: Mark Salter <msalter@redhat.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"x86@kernel.org" <x86@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH V4 2/3] arm64: support initrd outside kernel linear map
Date: Tue, 8 Sep 2015 12:31:13 +0100 [thread overview]
Message-ID: <20150908113113.GA20562@leverpostej> (raw)
In-Reply-To: <1439830867-14935-3-git-send-email-msalter@redhat.com>
Hi Mark,
On Mon, Aug 17, 2015 at 06:01:06PM +0100, Mark Salter wrote:
> The use of mem= could leave part or all of the initrd outside of
> the kernel linear map. This will lead to an error when unpacking
> the initrd and a probable failure to boot. This patch catches that
> situation and relocates the initrd to be fully within the linear
> map.
With next-20150908, this patch results in a confusing message at boot when not
using an initrd:
Moving initrd from [4080000000-407fffffff] to [9fff49000-9fff48fff]
I think that can be solved by folding in the diff below.
Thanks,
Mark.
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 6bab21f..2322479 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -364,6 +364,8 @@ static void __init relocate_initrd(void)
to_free = ram_end - orig_start;
size = orig_end - orig_start;
+ if (!size)
+ return;
/* initrd needs to be relocated completely inside linear mapping */
new_start = memblock_find_in_range(0, PFN_PHYS(max_pfn),
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 2/3] arm64: support initrd outside kernel linear map
Date: Tue, 8 Sep 2015 12:31:13 +0100 [thread overview]
Message-ID: <20150908113113.GA20562@leverpostej> (raw)
In-Reply-To: <1439830867-14935-3-git-send-email-msalter@redhat.com>
Hi Mark,
On Mon, Aug 17, 2015 at 06:01:06PM +0100, Mark Salter wrote:
> The use of mem= could leave part or all of the initrd outside of
> the kernel linear map. This will lead to an error when unpacking
> the initrd and a probable failure to boot. This patch catches that
> situation and relocates the initrd to be fully within the linear
> map.
With next-20150908, this patch results in a confusing message at boot when not
using an initrd:
Moving initrd from [4080000000-407fffffff] to [9fff49000-9fff48fff]
I think that can be solved by folding in the diff below.
Thanks,
Mark.
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 6bab21f..2322479 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -364,6 +364,8 @@ static void __init relocate_initrd(void)
to_free = ram_end - orig_start;
size = orig_end - orig_start;
+ if (!size)
+ return;
/* initrd needs to be relocated completely inside linear mapping */
new_start = memblock_find_in_range(0, PFN_PHYS(max_pfn),
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Mark Salter <msalter@redhat.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"x86@kernel.org" <x86@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH V4 2/3] arm64: support initrd outside kernel linear map
Date: Tue, 8 Sep 2015 12:31:13 +0100 [thread overview]
Message-ID: <20150908113113.GA20562@leverpostej> (raw)
In-Reply-To: <1439830867-14935-3-git-send-email-msalter@redhat.com>
Hi Mark,
On Mon, Aug 17, 2015 at 06:01:06PM +0100, Mark Salter wrote:
> The use of mem= could leave part or all of the initrd outside of
> the kernel linear map. This will lead to an error when unpacking
> the initrd and a probable failure to boot. This patch catches that
> situation and relocates the initrd to be fully within the linear
> map.
With next-20150908, this patch results in a confusing message at boot when not
using an initrd:
Moving initrd from [4080000000-407fffffff] to [9fff49000-9fff48fff]
I think that can be solved by folding in the diff below.
Thanks,
Mark.
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 6bab21f..2322479 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -364,6 +364,8 @@ static void __init relocate_initrd(void)
to_free = ram_end - orig_start;
size = orig_end - orig_start;
+ if (!size)
+ return;
/* initrd needs to be relocated completely inside linear mapping */
new_start = memblock_find_in_range(0, PFN_PHYS(max_pfn),
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-08 11:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 17:01 [PATCH V4 0/3] mm: Add generic copy from early unmapped RAM Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-17 17:01 ` [PATCH V4 1/3] mm: add utility for early copy from unmapped ram Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-17 17:01 ` [PATCH V4 2/3] arm64: support initrd outside kernel linear map Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-18 8:56 ` Will Deacon
2015-08-18 8:56 ` Will Deacon
2015-08-18 8:56 ` Will Deacon
2015-09-08 11:31 ` Mark Rutland [this message]
2015-09-08 11:31 ` Mark Rutland
2015-09-08 11:31 ` Mark Rutland
2015-10-06 17:11 ` Mark Rutland
2015-10-06 17:11 ` Mark Rutland
2015-10-06 17:11 ` Mark Rutland
2015-10-06 17:16 ` Mark Salter
2015-10-06 17:16 ` Mark Salter
2015-10-06 17:16 ` Mark Salter
2015-10-08 8:49 ` Christoffer Dall
2015-10-08 8:49 ` Christoffer Dall
2015-10-08 8:49 ` Christoffer Dall
2015-10-08 9:18 ` yalin wang
2015-10-08 9:18 ` yalin wang
2015-10-08 9:18 ` yalin wang
2015-10-08 9:40 ` Russell King - ARM Linux
2015-10-08 9:40 ` Russell King - ARM Linux
2015-10-08 9:40 ` Russell King - ARM Linux
2015-10-08 9:40 ` Russell King - ARM Linux
2015-08-17 17:01 ` [PATCH V4 3/3] x86: use generic early mem copy Mark Salter
2015-08-17 17:01 ` Mark Salter
2015-08-17 17:01 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908113113.GA20562@leverpostej \
--to=mark.rutland@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=msalter@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.