From: Andrew Lunn <andrew@lunn.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCHv2 3/3] devicetree: Add led-backlight binding
Date: Tue, 08 Sep 2015 13:41:40 +0000 [thread overview]
Message-ID: <20150908134140.GH30736@lunn.ch> (raw)
In-Reply-To: <1441711176-4258-4-git-send-email-tomi.valkeinen@ti.com>
On Tue, Sep 08, 2015 at 02:19:36PM +0300, Tomi Valkeinen wrote:
> Add DT binding for led-backlight.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> .../bindings/video/backlight/led-backlight.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/backlight/led-backlight.txt
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/led-backlight.txt b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
> new file mode 100644
> index 000000000000..fb77051ac230
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
> @@ -0,0 +1,30 @@
> +led-backlight bindings
> +
> +Required properties:
> + - compatible: "led-backlight"
> + - leds: phandle to a led OF node [0]
> + - brightness-levels: Array of distinct LED brightness levels. These
> + are in the range from 0 to 255, passed to the LED class driver.
> + - default-brightness-level: the default brightness level (index into the
> + array defined by the "brightness-levels" property)
> + - power-supply: regulator for supply voltage
Hi Tomi
Maybe this regulator should be optional? I could imagine blacklights
without one, in none power sensitive cases, e.g. industrial PC with a
touch screen display, train ticket machine, etc.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCHv2 3/3] devicetree: Add led-backlight binding
Date: Tue, 8 Sep 2015 15:41:40 +0200 [thread overview]
Message-ID: <20150908134140.GH30736@lunn.ch> (raw)
In-Reply-To: <1441711176-4258-4-git-send-email-tomi.valkeinen@ti.com>
On Tue, Sep 08, 2015 at 02:19:36PM +0300, Tomi Valkeinen wrote:
> Add DT binding for led-backlight.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> .../bindings/video/backlight/led-backlight.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/backlight/led-backlight.txt
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/led-backlight.txt b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
> new file mode 100644
> index 000000000000..fb77051ac230
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
> @@ -0,0 +1,30 @@
> +led-backlight bindings
> +
> +Required properties:
> + - compatible: "led-backlight"
> + - leds: phandle to a led OF node [0]
> + - brightness-levels: Array of distinct LED brightness levels. These
> + are in the range from 0 to 255, passed to the LED class driver.
> + - default-brightness-level: the default brightness level (index into the
> + array defined by the "brightness-levels" property)
> + - power-supply: regulator for supply voltage
Hi Tomi
Maybe this regulator should be optional? I could imagine blacklights
without one, in none power sensitive cases, e.g. industrial PC with a
touch screen display, train ticket machine, etc.
Andrew
next prev parent reply other threads:[~2015-09-08 13:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 11:19 [PATCHv2 0/3] backlight: led-backlight driver Tomi Valkeinen
2015-09-08 11:19 ` Tomi Valkeinen
2015-09-08 11:19 ` [PATCHv2 1/3] leds: Add of_led_get() and led_put() Tomi Valkeinen
2015-09-08 11:19 ` Tomi Valkeinen
2015-09-08 13:20 ` Jacek Anaszewski
2015-09-08 13:20 ` Jacek Anaszewski
2015-09-08 14:04 ` Jacek Anaszewski
2015-09-08 14:04 ` Jacek Anaszewski
2015-09-09 12:16 ` Tomi Valkeinen
2015-09-09 12:16 ` Tomi Valkeinen
2015-09-09 12:40 ` Jacek Anaszewski
2015-09-09 12:40 ` Jacek Anaszewski
2015-09-09 12:00 ` Tomi Valkeinen
2015-09-09 12:00 ` Tomi Valkeinen
2015-09-08 11:19 ` [PATCHv2 2/3] backlight: add led-backlight driver Tomi Valkeinen
2015-09-08 11:19 ` Tomi Valkeinen
2015-09-08 11:19 ` [PATCHv2 3/3] devicetree: Add led-backlight binding Tomi Valkeinen
2015-09-08 11:19 ` Tomi Valkeinen
2015-09-08 13:41 ` Andrew Lunn [this message]
2015-09-08 13:41 ` Andrew Lunn
2015-09-09 11:47 ` Tomi Valkeinen
2015-09-09 11:47 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908134140.GH30736@lunn.ch \
--to=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.