From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Nathan Rossi <nathan@nathanrossi.com>
Cc: "Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
crosthwaite.peter@gmail.com, alistair.francis@xilinx.com,
qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size
Date: Tue, 8 Sep 2015 16:51:02 +0200 [thread overview]
Message-ID: <20150908145102.GG12618@toto> (raw)
In-Reply-To: <1441719672-25296-1-git-send-email-nathan@nathanrossi.com>
On Tue, Sep 08, 2015 at 11:41:12PM +1000, Nathan Rossi wrote:
> The GIC in ZynqMP cover a 64K address space, however the actual
> registers are decoded within a 4K address space and mirrored at the 4K
> boundaries. This change fixes the defined size for these regions as it
> was set to 0x4000/16K incorrectly.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Adding Alistair, Crosthwaite and Maydell.
Thanks Nathan!
Edgar
> ---
> include/hw/arm/xlnx-zynqmp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
> index 6ccb57b..23b8453 100644
> --- a/include/hw/arm/xlnx-zynqmp.h
> +++ b/include/hw/arm/xlnx-zynqmp.h
> @@ -44,7 +44,7 @@
> * number of memory region aliases.
> */
>
> -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000
> +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000
> #define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1)
>
> typedef struct XlnxZynqMPState {
> --
> 2.5.1
>
next prev parent reply other threads:[~2015-09-08 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 13:41 [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size Nathan Rossi
2015-09-08 14:51 ` Edgar E. Iglesias [this message]
2015-09-11 15:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908145102.GG12618@toto \
--to=edgar.iglesias@xilinx.com \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=nathan@nathanrossi.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.