* [review-request][PATCH] toaster: increase waiting time
@ 2015-09-08 8:50 Ed Bartosh
2015-09-08 15:46 ` Brian Avery
0 siblings, 1 reply; 3+ messages in thread
From: Ed Bartosh @ 2015-09-08 8:50 UTC (permalink / raw)
To: toaster
Increased waiting time for toasterUI from 10 to 25 seconds. Bitbake
takes longer time to start, so toaster should wait longer.
[YOCTO #8240]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
bitbake/lib/toaster/bldcontrol/localhostbecontroller.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
index 231a7d3..a9909b8 100644
--- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -140,7 +140,7 @@ class LocalhostBEController(BuildEnvironmentController):
retries = 0
started = False
- while not started and retries < 10:
+ while not started and retries < 50:
started = _toaster_ui_started(toaster_ui_log_filepath, toaster_ui_log_filelength)
import time
logger.debug("localhostbecontroller: Waiting bitbake server to start")
@@ -150,7 +150,7 @@ class LocalhostBEController(BuildEnvironmentController):
if not started:
toaster_ui_log = open(os.path.join(self.be.builddir, "toaster_ui.log"), "r").read()
toaster_server_log = open(os.path.join(self.be.builddir, "toaster_server.log"), "r").read()
- raise BuildSetupException("localhostbecontroller: Bitbake server did not start in 5 seconds, aborting (Error: '%s' '%s')" % (toaster_ui_log, toaster_server_log))
+ raise BuildSetupException("localhostbecontroller: Bitbake server did not start in 25 seconds, aborting (Error: '%s' '%s')" % (toaster_ui_log, toaster_server_log))
logger.debug("localhostbecontroller: Started bitbake server")
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [review-request][PATCH] toaster: increase waiting time
2015-09-08 8:50 [review-request][PATCH] toaster: increase waiting time Ed Bartosh
@ 2015-09-08 15:46 ` Brian Avery
2015-09-09 10:55 ` Ed Bartosh
0 siblings, 1 reply; 3+ messages in thread
From: Brian Avery @ 2015-09-08 15:46 UTC (permalink / raw)
To: Ed Bartosh; +Cc: toaster
Do we know why bitbake suddenly took longer to start up? I did not
see this bug on either of my development machines.
-b
On Tue, Sep 8, 2015 at 1:50 AM, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> Increased waiting time for toasterUI from 10 to 25 seconds. Bitbake
> takes longer time to start, so toaster should wait longer.
>
> [YOCTO #8240]
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> bitbake/lib/toaster/bldcontrol/localhostbecontroller.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> index 231a7d3..a9909b8 100644
> --- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> +++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> @@ -140,7 +140,7 @@ class LocalhostBEController(BuildEnvironmentController):
>
> retries = 0
> started = False
> - while not started and retries < 10:
> + while not started and retries < 50:
> started = _toaster_ui_started(toaster_ui_log_filepath, toaster_ui_log_filelength)
> import time
> logger.debug("localhostbecontroller: Waiting bitbake server to start")
> @@ -150,7 +150,7 @@ class LocalhostBEController(BuildEnvironmentController):
> if not started:
> toaster_ui_log = open(os.path.join(self.be.builddir, "toaster_ui.log"), "r").read()
> toaster_server_log = open(os.path.join(self.be.builddir, "toaster_server.log"), "r").read()
> - raise BuildSetupException("localhostbecontroller: Bitbake server did not start in 5 seconds, aborting (Error: '%s' '%s')" % (toaster_ui_log, toaster_server_log))
> + raise BuildSetupException("localhostbecontroller: Bitbake server did not start in 25 seconds, aborting (Error: '%s' '%s')" % (toaster_ui_log, toaster_server_log))
>
> logger.debug("localhostbecontroller: Started bitbake server")
>
> --
> 2.1.4
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [review-request][PATCH] toaster: increase waiting time
2015-09-08 15:46 ` Brian Avery
@ 2015-09-09 10:55 ` Ed Bartosh
0 siblings, 0 replies; 3+ messages in thread
From: Ed Bartosh @ 2015-09-09 10:55 UTC (permalink / raw)
To: Brian Avery; +Cc: toaster
On Tue, Sep 08, 2015 at 08:46:22AM -0700, Brian Avery wrote:
> Do we know why bitbake suddenly took longer to start up? I did not
> see this bug on either of my development machines.
It turned out that it was caused by recent bitbake change. The issue was
fixed in bitbake code, but I'd suggest to merge my patch anyway.
Please, see https://bugzilla.yoctoproject.org/show_bug.cgi?id=8240 for
details.
Regards,
Ed
> On Tue, Sep 8, 2015 at 1:50 AM, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> > Increased waiting time for toasterUI from 10 to 25 seconds. Bitbake
> > takes longer time to start, so toaster should wait longer.
> >
> > [YOCTO #8240]
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > ---
> > bitbake/lib/toaster/bldcontrol/localhostbecontroller.py | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> > index 231a7d3..a9909b8 100644
> > --- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> > +++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> > @@ -140,7 +140,7 @@ class LocalhostBEController(BuildEnvironmentController):
> >
> > retries = 0
> > started = False
> > - while not started and retries < 10:
> > + while not started and retries < 50:
> > started = _toaster_ui_started(toaster_ui_log_filepath, toaster_ui_log_filelength)
> > import time
> > logger.debug("localhostbecontroller: Waiting bitbake server to start")
> > @@ -150,7 +150,7 @@ class LocalhostBEController(BuildEnvironmentController):
> > if not started:
> > toaster_ui_log = open(os.path.join(self.be.builddir, "toaster_ui.log"), "r").read()
> > toaster_server_log = open(os.path.join(self.be.builddir, "toaster_server.log"), "r").read()
> > - raise BuildSetupException("localhostbecontroller: Bitbake server did not start in 5 seconds, aborting (Error: '%s' '%s')" % (toaster_ui_log, toaster_server_log))
> > + raise BuildSetupException("localhostbecontroller: Bitbake server did not start in 25 seconds, aborting (Error: '%s' '%s')" % (toaster_ui_log, toaster_server_log))
> >
> > logger.debug("localhostbecontroller: Started bitbake server")
> >
> > --
> > 2.1.4
> >
> > --
> > _______________________________________________
> > toaster mailing list
> > toaster@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-09 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08 8:50 [review-request][PATCH] toaster: increase waiting time Ed Bartosh
2015-09-08 15:46 ` Brian Avery
2015-09-09 10:55 ` Ed Bartosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.