From: Alban <albeu@free.fr>
To: Alexander Couzens <lynxis@fe80.eu>
Cc: Alban <albeu@free.fr>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] MIPS: ath79: set missing irq ack handler for ar7100-misc-intc irq chip
Date: Wed, 9 Sep 2015 15:53:55 +0200 [thread overview]
Message-ID: <20150909155355.7e4b1c76@avionic-0020> (raw)
In-Reply-To: <1441790178-9573-2-git-send-email-lynxis@fe80.eu>
On Wed, 9 Sep 2015 11:16:17 +0200
Alexander Couzens <lynxis@fe80.eu> wrote:
> The irq ack handler was forgotten while introducing OF support.
> Only ar71xx and ar933x based devices require it.
>
> Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
> ---
> arch/mips/ath79/irq.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c
> index afb0096..c9c0124 100644
> --- a/arch/mips/ath79/irq.c
> +++ b/arch/mips/ath79/irq.c
> @@ -308,8 +308,16 @@ static int __init ath79_misc_intc_of_init(
>
> return 0;
> }
> -IRQCHIP_DECLARE(ath79_misc_intc, "qca,ar7100-misc-intc",
> - ath79_misc_intc_of_init);
> +
> +static int __init ar7100_misc_intc_of_init(
> + struct device_node *node, struct device_node *parent)
> +{
> + ath79_misc_irq_chip.irq_mask_ack = ar71xx_misc_irq_mask;
> + return ath79_misc_intc_of_init(node, parent);
> +}
> +
> +IRQCHIP_DECLARE(ar7100_misc_intc, "qca,ar7100-misc-intc",
> + ar7100_misc_intc_of_init);
>
> static int __init ar79_cpu_intc_of_init(
> struct device_node *node, struct device_node *parent)
Acked-by: Alban Bedel <albeu@free.fr>
WARNING: multiple messages have this Message-ID (diff)
From: Alban <albeu-GANU6spQydw@public.gmane.org>
To: Alexander Couzens <lynxis-qyMx1GtpvWw@public.gmane.org>
Cc: Alban <albeu-GANU6spQydw@public.gmane.org>,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/2] MIPS: ath79: set missing irq ack handler for ar7100-misc-intc irq chip
Date: Wed, 9 Sep 2015 15:53:55 +0200 [thread overview]
Message-ID: <20150909155355.7e4b1c76@avionic-0020> (raw)
In-Reply-To: <1441790178-9573-2-git-send-email-lynxis-qyMx1GtpvWw@public.gmane.org>
On Wed, 9 Sep 2015 11:16:17 +0200
Alexander Couzens <lynxis-qyMx1GtpvWw@public.gmane.org> wrote:
> The irq ack handler was forgotten while introducing OF support.
> Only ar71xx and ar933x based devices require it.
>
> Signed-off-by: Alexander Couzens <lynxis-qyMx1GtpvWw@public.gmane.org>
> ---
> arch/mips/ath79/irq.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c
> index afb0096..c9c0124 100644
> --- a/arch/mips/ath79/irq.c
> +++ b/arch/mips/ath79/irq.c
> @@ -308,8 +308,16 @@ static int __init ath79_misc_intc_of_init(
>
> return 0;
> }
> -IRQCHIP_DECLARE(ath79_misc_intc, "qca,ar7100-misc-intc",
> - ath79_misc_intc_of_init);
> +
> +static int __init ar7100_misc_intc_of_init(
> + struct device_node *node, struct device_node *parent)
> +{
> + ath79_misc_irq_chip.irq_mask_ack = ar71xx_misc_irq_mask;
> + return ath79_misc_intc_of_init(node, parent);
> +}
> +
> +IRQCHIP_DECLARE(ar7100_misc_intc, "qca,ar7100-misc-intc",
> + ar7100_misc_intc_of_init);
>
> static int __init ar79_cpu_intc_of_init(
> struct device_node *node, struct device_node *parent)
Acked-by: Alban Bedel <albeu-GANU6spQydw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-09 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 9:16 [PATCH v2 0/2] ath79 misc irq controller Alexander Couzens
2015-09-09 9:16 ` Alexander Couzens
2015-09-09 9:16 ` [PATCH v2 1/2] MIPS: ath79: set missing irq ack handler for ar7100-misc-intc irq chip Alexander Couzens
2015-09-09 13:53 ` Alban [this message]
2015-09-09 13:53 ` Alban
2015-09-09 9:16 ` [PATCH v2 2/2] MIPS: ath79: add irq chip ar7240-misc-intc Alexander Couzens
2015-09-09 13:54 ` Alban
2015-09-09 13:54 ` Alban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909155355.7e4b1c76@avionic-0020 \
--to=albeu@free.fr \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=lynxis@fe80.eu \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.