From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/ls1021a: Add Sleep feature for ls1021
Date: Thu, 10 Sep 2015 10:59:20 +0100 [thread overview]
Message-ID: <20150910095920.GB29293@leverpostej> (raw)
In-Reply-To: <1441877796-32232-1-git-send-email-dongsheng.wang@freescale.com>
On Thu, Sep 10, 2015 at 10:36:36AM +0100, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> Based on PSCI framework, add system STANDBY implement for ls1021 platform.
>
> Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index fb689d8..d7a2d1d 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -90,6 +90,7 @@ ifeq ($(CONFIG_SUSPEND),y)
> AFLAGS_suspend-imx6.o :=-Wa,-march=armv7-a
> obj-$(CONFIG_SOC_IMX6) += suspend-imx6.o
> obj-$(CONFIG_SOC_IMX53) += suspend-imx53.o
> +obj-$(CONFIG_SOC_LS1021A) += pm-ls1.o
> endif
> obj-$(CONFIG_SOC_IMX6) += pm-imx6.o
>
> diff --git a/arch/arm/mach-imx/pm-ls1.c b/arch/arm/mach-imx/pm-ls1.c
> new file mode 100644
> index 0000000..f80b24d
> --- /dev/null
> +++ b/arch/arm/mach-imx/pm-ls1.c
> @@ -0,0 +1,222 @@
> +/*
> + * Support Power Management Control for LS1
> + *
> + * Copyright 2015 Freescale Semiconductor Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/of_platform.h>
> +#include <linux/of_address.h>
> +#include <linux/psci.h>
> +#include <linux/suspend.h>
> +
> +#include <uapi/linux/psci.h>
> +
> +#include <asm/cacheflush.h>
> +#include <asm/psci.h>
NAK.
No new platform code should be calling the PSCI functions directly; you
should not need to include these files in platform code.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Dongsheng Wang <dongsheng.wang@freescale.com>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"alison.wang@freescale.com" <alison.wang@freescale.com>,
"chenhui.zhao@freescale.com" <chenhui.zhao@freescale.com>,
"jason.jin@freescale.com" <jason.jin@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm/ls1021a: Add Sleep feature for ls1021
Date: Thu, 10 Sep 2015 10:59:20 +0100 [thread overview]
Message-ID: <20150910095920.GB29293@leverpostej> (raw)
In-Reply-To: <1441877796-32232-1-git-send-email-dongsheng.wang@freescale.com>
On Thu, Sep 10, 2015 at 10:36:36AM +0100, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> Based on PSCI framework, add system STANDBY implement for ls1021 platform.
>
> Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index fb689d8..d7a2d1d 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -90,6 +90,7 @@ ifeq ($(CONFIG_SUSPEND),y)
> AFLAGS_suspend-imx6.o :=-Wa,-march=armv7-a
> obj-$(CONFIG_SOC_IMX6) += suspend-imx6.o
> obj-$(CONFIG_SOC_IMX53) += suspend-imx53.o
> +obj-$(CONFIG_SOC_LS1021A) += pm-ls1.o
> endif
> obj-$(CONFIG_SOC_IMX6) += pm-imx6.o
>
> diff --git a/arch/arm/mach-imx/pm-ls1.c b/arch/arm/mach-imx/pm-ls1.c
> new file mode 100644
> index 0000000..f80b24d
> --- /dev/null
> +++ b/arch/arm/mach-imx/pm-ls1.c
> @@ -0,0 +1,222 @@
> +/*
> + * Support Power Management Control for LS1
> + *
> + * Copyright 2015 Freescale Semiconductor Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/of_platform.h>
> +#include <linux/of_address.h>
> +#include <linux/psci.h>
> +#include <linux/suspend.h>
> +
> +#include <uapi/linux/psci.h>
> +
> +#include <asm/cacheflush.h>
> +#include <asm/psci.h>
NAK.
No new platform code should be calling the PSCI functions directly; you
should not need to include these files in platform code.
Thanks,
Mark.
next prev parent reply other threads:[~2015-09-10 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 9:36 [PATCH] arm/ls1021a: Add Sleep feature for ls1021 Dongsheng Wang
2015-09-10 9:36 ` Dongsheng Wang
2015-09-10 9:59 ` Mark Rutland [this message]
2015-09-10 9:59 ` Mark Rutland
2015-09-11 3:42 ` Wang Dongsheng
2015-09-11 3:53 ` Wang Dongsheng
2015-09-17 12:31 ` Mark Rutland
2015-09-17 12:31 ` Mark Rutland
2015-09-18 2:37 ` Wang Dongsheng
2015-09-18 7:46 ` Lorenzo Pieralisi
2015-09-18 7:46 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910095920.GB29293@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.