From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
Date: Thu, 10 Sep 2015 17:24:15 +0200 [thread overview]
Message-ID: <20150910152415.GN3237@piout.net> (raw)
In-Reply-To: <fca26d7ecb73e9691da4ee85e7e5bd8462638752.1441897573.git.nicolas.ferre@atmel.com>
Hi,
On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
> From: Josh Wu <josh.wu@atmel.com>
>
> Correct the led labels in at91sam9n12ek.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> index efa75064d38a..186a1705f8d3 100644
> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> @@ -204,13 +204,13 @@
> };
>
> d9 {
> - label = "d6";
> + label = "d9";
> gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "nand-disk";
> };
>
> d10 {
> - label = "d7";
> + label = "d10";
> gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
The only concern being that this renaming will break userspace software
assuming the LEDs are wrongly named. Is there anything that has been
released by atmel that uses the wrong names (and my guess is yess and
that is why there are named as such) and do you care about it?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Josh Wu <josh.wu@atmel.com>,
linux-arm-kernel@lists.infradead.org,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
Date: Thu, 10 Sep 2015 17:24:15 +0200 [thread overview]
Message-ID: <20150910152415.GN3237@piout.net> (raw)
In-Reply-To: <fca26d7ecb73e9691da4ee85e7e5bd8462638752.1441897573.git.nicolas.ferre@atmel.com>
Hi,
On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
> From: Josh Wu <josh.wu@atmel.com>
>
> Correct the led labels in at91sam9n12ek.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> index efa75064d38a..186a1705f8d3 100644
> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> @@ -204,13 +204,13 @@
> };
>
> d9 {
> - label = "d6";
> + label = "d9";
> gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "nand-disk";
> };
>
> d10 {
> - label = "d7";
> + label = "d10";
> gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
The only concern being that this renaming will break userspace software
assuming the LEDs are wrongly named. Is there anything that has been
released by atmel that uses the wrong names (and my guess is yess and
that is why there are named as such) and do you care about it?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-10 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 15:09 [PATCH 1/2] sama5d33ek: enable led D3 Nicolas Ferre
2015-09-10 15:09 ` Nicolas Ferre
2015-09-10 15:09 ` [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Nicolas Ferre
2015-09-10 15:09 ` Nicolas Ferre
2015-09-10 15:24 ` Alexandre Belloni [this message]
2015-09-10 15:24 ` Alexandre Belloni
2015-09-18 13:46 ` Nicolas Ferre
2015-09-18 13:46 ` Nicolas Ferre
2015-09-18 22:08 ` Alexandre Belloni
2015-09-18 22:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910152415.GN3237@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.