All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jarkko Nikula
	<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: spidev: fix possible NULL dereference
Date: Fri, 11 Sep 2015 18:19:45 +0530	[thread overview]
Message-ID: <20150911124945.GA10016@sudip-pc> (raw)
In-Reply-To: <20150911122513.GT12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Fri, Sep 11, 2015 at 01:25:13PM +0100, Mark Brown wrote:
> On Fri, Sep 11, 2015 at 03:11:32PM +0300, Jarkko Nikula wrote:
> 
> > Actually this fixes a *real* NULL dereference case but it is not related to
> > normal open/close life cycle of spidev. It requires that spidev is kept open
> > when SPI master is removed.
> 
> > spidev->spi is set to NULL in spidev_remove() and it is called before
> > spidev_release() in case master is removed while spidev is in use
> 
> > It would be good to update this to commit log, add a tag below and Cc
> > <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> 
> > Fixes: 9169051617df ("spi: spidev: Don't mangle max_speed_hz in underlying
> > spi device")
> 
> The patch was already applied :(
Applied? But usually I will receive an auto mail from you after applying.
I dont think I have received any.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: spidev: fix possible NULL dereference
Date: Fri, 11 Sep 2015 18:19:45 +0530	[thread overview]
Message-ID: <20150911124945.GA10016@sudip-pc> (raw)
In-Reply-To: <20150911122513.GT12027@sirena.org.uk>

On Fri, Sep 11, 2015 at 01:25:13PM +0100, Mark Brown wrote:
> On Fri, Sep 11, 2015 at 03:11:32PM +0300, Jarkko Nikula wrote:
> 
> > Actually this fixes a *real* NULL dereference case but it is not related to
> > normal open/close life cycle of spidev. It requires that spidev is kept open
> > when SPI master is removed.
> 
> > spidev->spi is set to NULL in spidev_remove() and it is called before
> > spidev_release() in case master is removed while spidev is in use
> 
> > It would be good to update this to commit log, add a tag below and Cc
> > <stable@vger.kernel.org>
> 
> > Fixes: 9169051617df ("spi: spidev: Don't mangle max_speed_hz in underlying
> > spi device")
> 
> The patch was already applied :(
Applied? But usually I will receive an auto mail from you after applying.
I dont think I have received any.

regards
sudip

  parent reply	other threads:[~2015-09-11 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 11:18 [PATCH] spi: spidev: fix possible NULL dereference Sudip Mukherjee
2015-09-10 11:18 ` Sudip Mukherjee
     [not found] ` <1441883893-20596-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-11 12:11   ` Jarkko Nikula
2015-09-11 12:11     ` Jarkko Nikula
     [not found]     ` <55F2C4F4.3090704-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-11 12:25       ` Mark Brown
2015-09-11 12:25         ` Mark Brown
     [not found]         ` <20150911122513.GT12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-11 12:49           ` Sudip Mukherjee [this message]
2015-09-11 12:49             ` Sudip Mukherjee
2015-09-11 14:21             ` Mark Brown
2015-09-11 14:21               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911124945.GA10016@sudip-pc \
    --to=sudipm.mukherjee-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.