From: Michael Turquette <mturquette@baylibre.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Thierry Reding <treding@nvidia.com>,
Anand Moon <linux.amoon@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Lukasz Majewski <l.majewski@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support
Date: Fri, 11 Sep 2015 08:25:51 -0700 [thread overview]
Message-ID: <20150911152551.3201.92278@quantum> (raw)
In-Reply-To: <1441892552-13819-1-git-send-email-javier@osg.samsung.com>
Quoting Javier Martinez Canillas (2015-09-10 06:42:32)
> The simplefb driver allows the kernel to render on a pre-allocated
> buffer that's been initialized by firmware before the kernel boots.
>
> This option was enabled to have display working on the Exynos5250
> Snow Chromebook by commit da9d0fbf5e9a ("ARM: exynos: defconfig
> update") since proper DRM/KMS support did not exist at that time.
>
> But now that the Exynos DRM driver has support for this hardware,
> there is no need to have simplefb enabled. In fact, if a user has
> a u-boot that injects the simplefb dev node to the FDT before pass
> it to the kernel, display won't be properly initialized and only a
> blank screen will be shown since there isn't a proper handoff from
> the simplefb driver to the Exynos DRM driver.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by/Tested-by: Michael Turquette <mturquette@baylibre.com>
Thanks, this resolved one of the issues I had with U-boot that injected
the simplefb node.
Regards,
Mike
>
> ---
>
> arch/arm/configs/exynos_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 62f677f76a0b..20d878c83193 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -139,7 +139,6 @@ CONFIG_DRM_EXYNOS_DSI=y
> CONFIG_DRM_EXYNOS_HDMI=y
> CONFIG_DRM_PANEL_SIMPLE=y
> CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=y
> -CONFIG_FB_SIMPLE=y
> CONFIG_EXYNOS_VIDEO=y
> CONFIG_EXYNOS_MIPI_DSI=y
> CONFIG_LCD_CLASS_DEVICE=y
> --
> 2.4.3
>
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@baylibre.com (Michael Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos_defconfig: Disable simplefb support
Date: Fri, 11 Sep 2015 08:25:51 -0700 [thread overview]
Message-ID: <20150911152551.3201.92278@quantum> (raw)
In-Reply-To: <1441892552-13819-1-git-send-email-javier@osg.samsung.com>
Quoting Javier Martinez Canillas (2015-09-10 06:42:32)
> The simplefb driver allows the kernel to render on a pre-allocated
> buffer that's been initialized by firmware before the kernel boots.
>
> This option was enabled to have display working on the Exynos5250
> Snow Chromebook by commit da9d0fbf5e9a ("ARM: exynos: defconfig
> update") since proper DRM/KMS support did not exist at that time.
>
> But now that the Exynos DRM driver has support for this hardware,
> there is no need to have simplefb enabled. In fact, if a user has
> a u-boot that injects the simplefb dev node to the FDT before pass
> it to the kernel, display won't be properly initialized and only a
> blank screen will be shown since there isn't a proper handoff from
> the simplefb driver to the Exynos DRM driver.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by/Tested-by: Michael Turquette <mturquette@baylibre.com>
Thanks, this resolved one of the issues I had with U-boot that injected
the simplefb node.
Regards,
Mike
>
> ---
>
> arch/arm/configs/exynos_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 62f677f76a0b..20d878c83193 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -139,7 +139,6 @@ CONFIG_DRM_EXYNOS_DSI=y
> CONFIG_DRM_EXYNOS_HDMI=y
> CONFIG_DRM_PANEL_SIMPLE=y
> CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=y
> -CONFIG_FB_SIMPLE=y
> CONFIG_EXYNOS_VIDEO=y
> CONFIG_EXYNOS_MIPI_DSI=y
> CONFIG_LCD_CLASS_DEVICE=y
> --
> 2.4.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Turquette <mturquette@baylibre.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: "Javier Martinez Canillas" <javier@osg.samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Thierry Reding" <treding@nvidia.com>,
"Anand Moon" <linux.amoon@gmail.com>,
"Russell King" <linux@arm.linux.org.uk>,
linux-samsung-soc@vger.kernel.org,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Lukasz Majewski" <l.majewski@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: exynos_defconfig: Disable simplefb support
Date: Fri, 11 Sep 2015 08:25:51 -0700 [thread overview]
Message-ID: <20150911152551.3201.92278@quantum> (raw)
In-Reply-To: <1441892552-13819-1-git-send-email-javier@osg.samsung.com>
Quoting Javier Martinez Canillas (2015-09-10 06:42:32)
> The simplefb driver allows the kernel to render on a pre-allocated
> buffer that's been initialized by firmware before the kernel boots.
>
> This option was enabled to have display working on the Exynos5250
> Snow Chromebook by commit da9d0fbf5e9a ("ARM: exynos: defconfig
> update") since proper DRM/KMS support did not exist at that time.
>
> But now that the Exynos DRM driver has support for this hardware,
> there is no need to have simplefb enabled. In fact, if a user has
> a u-boot that injects the simplefb dev node to the FDT before pass
> it to the kernel, display won't be properly initialized and only a
> blank screen will be shown since there isn't a proper handoff from
> the simplefb driver to the Exynos DRM driver.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by/Tested-by: Michael Turquette <mturquette@baylibre.com>
Thanks, this resolved one of the issues I had with U-boot that injected
the simplefb node.
Regards,
Mike
>
> ---
>
> arch/arm/configs/exynos_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 62f677f76a0b..20d878c83193 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -139,7 +139,6 @@ CONFIG_DRM_EXYNOS_DSI=y
> CONFIG_DRM_EXYNOS_HDMI=y
> CONFIG_DRM_PANEL_SIMPLE=y
> CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=y
> -CONFIG_FB_SIMPLE=y
> CONFIG_EXYNOS_VIDEO=y
> CONFIG_EXYNOS_MIPI_DSI=y
> CONFIG_LCD_CLASS_DEVICE=y
> --
> 2.4.3
>
next prev parent reply other threads:[~2015-09-11 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 13:42 [PATCH] ARM: exynos_defconfig: Disable simplefb support Javier Martinez Canillas
2015-09-10 13:42 ` Javier Martinez Canillas
2015-09-11 5:01 ` Krzysztof Kozlowski
2015-09-11 5:01 ` Krzysztof Kozlowski
2015-09-11 7:07 ` Javier Martinez Canillas
2015-09-11 7:07 ` Javier Martinez Canillas
2015-09-11 7:16 ` Krzysztof Kozlowski
2015-09-11 7:16 ` Krzysztof Kozlowski
2015-09-11 7:40 ` Javier Martinez Canillas
2015-09-11 7:40 ` Javier Martinez Canillas
2015-09-11 15:25 ` Michael Turquette [this message]
2015-09-11 15:25 ` Michael Turquette
2015-09-11 15:25 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911152551.3201.92278@quantum \
--to=mturquette@baylibre.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.