From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andy Gross <agross@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: qcom: scm: Add function stubs for ARM64
Date: Fri, 11 Sep 2015 18:56:49 +0100 [thread overview]
Message-ID: <20150911175649.GZ21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1441993856-30178-1-git-send-email-agross@codeaurora.org>
On Fri, Sep 11, 2015 at 12:50:56PM -0500, Andy Gross wrote:
> This patch adds stubs for the SCM functions exposed in the QCOM SCM API.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
> drivers/firmware/Makefile | 4 +++
> drivers/firmware/qcom_scm-64.c | 63 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 drivers/firmware/qcom_scm-64.c
>
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 4a4b897..2f810c2 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -12,8 +12,12 @@ obj-$(CONFIG_ISCSI_IBFT_FIND) += iscsi_ibft_find.o
> obj-$(CONFIG_ISCSI_IBFT) += iscsi_ibft.o
> obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o
> obj-$(CONFIG_QCOM_SCM) += qcom_scm.o
> +ifdef CONFIG_ARM64
> +obj-$(CONFIG_QCOM_SCM) += qcom_scm-64.o
> +else
> obj-$(CONFIG_QCOM_SCM) += qcom_scm-32.o
> CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
> +endif
Can we not start doing stuff like this. Use the Kconfig to control what
you build, not the Makefile system.
config QCOM_SCM_32
def_bool y
depends on QCOM_SCM && ARM
config QCOM_SCM_64
def_bool y
depends on QCOM_SCM && ARM64
and then use those in the makefile.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] firmware: qcom: scm: Add function stubs for ARM64
Date: Fri, 11 Sep 2015 18:56:49 +0100 [thread overview]
Message-ID: <20150911175649.GZ21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1441993856-30178-1-git-send-email-agross@codeaurora.org>
On Fri, Sep 11, 2015 at 12:50:56PM -0500, Andy Gross wrote:
> This patch adds stubs for the SCM functions exposed in the QCOM SCM API.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
> drivers/firmware/Makefile | 4 +++
> drivers/firmware/qcom_scm-64.c | 63 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 drivers/firmware/qcom_scm-64.c
>
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 4a4b897..2f810c2 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -12,8 +12,12 @@ obj-$(CONFIG_ISCSI_IBFT_FIND) += iscsi_ibft_find.o
> obj-$(CONFIG_ISCSI_IBFT) += iscsi_ibft.o
> obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o
> obj-$(CONFIG_QCOM_SCM) += qcom_scm.o
> +ifdef CONFIG_ARM64
> +obj-$(CONFIG_QCOM_SCM) += qcom_scm-64.o
> +else
> obj-$(CONFIG_QCOM_SCM) += qcom_scm-32.o
> CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
> +endif
Can we not start doing stuff like this. Use the Kconfig to control what
you build, not the Makefile system.
config QCOM_SCM_32
def_bool y
depends on QCOM_SCM && ARM
config QCOM_SCM_64
def_bool y
depends on QCOM_SCM && ARM64
and then use those in the makefile.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-09-11 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 17:50 [PATCH] firmware: qcom: scm: Add function stubs for ARM64 Andy Gross
2015-09-11 17:50 ` Andy Gross
2015-09-11 17:56 ` Russell King - ARM Linux [this message]
2015-09-11 17:56 ` Russell King - ARM Linux
2015-09-11 19:20 ` Andy Gross
2015-09-11 19:20 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911175649.GZ21084@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=agross@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.