All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: ltp@lists.linux.it
Subject: [LTP] LTP and commit e1d7ba8735551ed7 ("time: Always make sure wall_to_monotonic isn't positive")
Date: Mon, 14 Sep 2015 14:46:05 +0100	[thread overview]
Message-ID: <20150914134603.GD7002@leverpostej> (raw)

Hi,

While testing v4.3-rc1 with the LTP, we spotted failures in a couple of
timekeeping tests, which seem to be a result of commit e1d7ba8735551ed7
("time: Always make sure wall_to_monotonic isn't positive").

In both cases this is because the new time would be before the boot
time, so I guess these are covered by the caveat at the end of the
commit message.

settimeofday01 [1] tries tries to settimeofday() with a timeval 100s and
100ns, while clock_gettime02 [2] tries to clock_settime to 1s and
100ns. Neither expect -EINVAL, and report failure with the new
behaviour.

While I don't know that any "real" software is affected, I thought I
should let you know.

Thanks,
Mark.

[1] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/syscalls/settimeofday/settimeofday01.c
[2] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/timers/clock_settime/clock_settime02.c

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: John Stultz <john.stultz@linaro.org>,
	Cyril Hrubis <chrubis@suse.cz>, Wang YanQing <udknight@gmail.com>
Cc: ltp@lists.linux.it, will.deacon@arm.com, linux-kernel@vger.kernel.org
Subject: LTP and commit e1d7ba8735551ed7 ("time: Always make sure wall_to_monotonic isn't positive")
Date: Mon, 14 Sep 2015 14:46:05 +0100	[thread overview]
Message-ID: <20150914134603.GD7002@leverpostej> (raw)

Hi,

While testing v4.3-rc1 with the LTP, we spotted failures in a couple of
timekeeping tests, which seem to be a result of commit e1d7ba8735551ed7
("time: Always make sure wall_to_monotonic isn't positive").

In both cases this is because the new time would be before the boot
time, so I guess these are covered by the caveat at the end of the
commit message.

settimeofday01 [1] tries tries to settimeofday() with a timeval 100s and
100ns, while clock_gettime02 [2] tries to clock_settime to 1s and
100ns. Neither expect -EINVAL, and report failure with the new
behaviour.

While I don't know that any "real" software is affected, I thought I
should let you know.

Thanks,
Mark.

[1] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/syscalls/settimeofday/settimeofday01.c
[2] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/timers/clock_settime/clock_settime02.c

             reply	other threads:[~2015-09-14 13:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 13:46 Mark Rutland [this message]
2015-09-14 13:46 ` LTP and commit e1d7ba8735551ed7 ("time: Always make sure wall_to_monotonic isn't positive") Mark Rutland
2015-09-15  8:37 ` [LTP] " Cyril Hrubis
2015-09-15  8:37   ` Cyril Hrubis
2015-09-24 14:51   ` [LTP] " Cyril Hrubis
2015-09-24 14:51     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914134603.GD7002@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.