From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Emilio Lopez <emilio@elopez.com.ar>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver
Date: Mon, 14 Sep 2015 16:40:40 +0200 [thread overview]
Message-ID: <20150914144040.GD4684@lukather> (raw)
In-Reply-To: <87wpvu2vzr.fsf@dell.be.48ers.dk>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
Hi Peter,
On Sun, Sep 13, 2015 at 05:13:12PM +0200, Peter Korsgaard wrote:
> >>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:
>
> > The A33 has different a different gates array than the A23, add the node to
> > the DT.
>
> NIT: 2x different.
Ah, good catch, thanks!
> Shouldn't the a23 one then move from sun8i-a23-a33.dtsi to
> sun8i-a23.dtsi?
It is, but in order to preserve bisectability, I declared the A33 node
first, that has precedence over the A23 still in the common DTSI, and
removed the A23 in the next patch.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver
Date: Mon, 14 Sep 2015 16:40:40 +0200 [thread overview]
Message-ID: <20150914144040.GD4684@lukather> (raw)
In-Reply-To: <87wpvu2vzr.fsf@dell.be.48ers.dk>
Hi Peter,
On Sun, Sep 13, 2015 at 05:13:12PM +0200, Peter Korsgaard wrote:
> >>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:
>
> > The A33 has different a different gates array than the A23, add the node to
> > the DT.
>
> NIT: 2x different.
Ah, good catch, thanks!
> Shouldn't the a23 one then move from sun8i-a23-a33.dtsi to
> sun8i-a23.dtsi?
It is, but in order to preserve bisectability, I declared the A33 node
first, that has precedence over the A23 still in the common DTSI, and
removed the A23 in the next patch.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150914/a3566487/attachment.sig>
next prev parent reply other threads:[~2015-09-14 14:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 13:26 [PATCH 0/4] ARM: sun8i: Fix A23 and A33 clock gates indices Maxime Ripard
2015-09-11 13:26 ` Maxime Ripard
2015-09-11 13:26 ` [PATCH 1/4] clk: sunxi: Add A33 gates support Maxime Ripard
2015-09-11 13:26 ` Maxime Ripard
2015-09-11 13:26 ` [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver Maxime Ripard
2015-09-11 13:26 ` Maxime Ripard
2015-09-13 15:13 ` Peter Korsgaard
2015-09-13 15:13 ` Peter Korsgaard
2015-09-13 15:13 ` Peter Korsgaard
2015-09-13 15:13 ` Peter Korsgaard
2015-09-14 14:40 ` Maxime Ripard [this message]
2015-09-14 14:40 ` Maxime Ripard
2015-09-11 13:26 ` [PATCH 3/4] ARM: sun8i: Move A23 AHB1 gates out of common DTSI Maxime Ripard
2015-09-11 13:26 ` Maxime Ripard
2015-09-11 13:26 ` [PATCH 4/4] ARM: sun8i: A23: Add missing msgbox gate Maxime Ripard
2015-09-11 13:26 ` Maxime Ripard
2015-09-16 5:42 ` [PATCH 0/4] ARM: sun8i: Fix A23 and A33 clock gates indices Chen-Yu Tsai
2015-09-16 5:42 ` Chen-Yu Tsai
2015-09-18 20:03 ` Maxime Ripard
2015-09-18 20:03 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914144040.GD4684@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter@korsgaard.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.