From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org, gregkh@linuxfoundation.org,
"open list:NETWORKING DRIVERS WIRELESS"
<linux-wireless@vger.kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Avri Altman <avri.altman@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Jiri Slaby <jirislaby@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Wang Long <long.wanglong@huawei.com>,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Ingo Molnar <mingo@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Davidlohr Bueso <dave@stgola>
Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Mon, 14 Sep 2015 21:17:08 +0530 [thread overview]
Message-ID: <20150914154708.GF32551@linux> (raw)
In-Reply-To: <1708603.aKpYchk1pa@wuerfel>
On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
> > goto error;
> >
> > if (write_support)
>
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.
Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?
Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.
@Greg: What all kernel versions you want this to be backported for?
--
viresh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Avri Altman <avri.altman@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Jiri Slaby <jirislaby@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Jaroslav Kysela <perex@perex.cz>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luciano Coelho <luciano.coelho@intel.com>,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Ingo Molnar <mingo@kernel.org>,
Hariprasad S <hariprasad@chelsio.com>,
Thomas Gleixner <tglx@linutronix.de>,
Davidlohr Bueso <dave@stgolabs.net>,
Eliad Peller <eliad@wizery.com>, Joonsoo Kim <js1304@gmail.com>,
Jonathan Corbet <corbet@lwn.net>, Joerg Roedel <joro@8bytes.org>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@opensource.wolfsonmicro.com>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists.infradead.org>,
Intel Linux Wireless <ilw@linux.intel.com>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Doug Thompson <dougthompson@xmission.com>,
Gustavo Padovan <gustavo@padovan.org>,
Sasha Levin <sasha.levin@oracle.com>,
Tomas Winkler <tomas.winkler@intel.com>,
sboyd@codeaurora.org,
"open list:B43 WIRELESS DRIVER" <b43-dev@lists.infradead.org>,
linaro-kernel@lists.linaro.org,
Johan Hedberg <johan.hedberg@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Arik Nemtsov <arik@wizery.com>,
Marcel Holtmann <marcel@holtmann.org>,
David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>, Mark Brown <broonie@kernel.org>,
Borislav Petkov <bp@alien8.de>, Oleg Nesterov <oleg@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
"moderated list:ARM64 PORT AARCH64 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Haggai Eran <haggaie@mellanox.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Chaya Rachel Ivgi <chaya.rachel.ivgi@intel.com>,
"open list:CISCO SCSI HBA DRIVER" <linux-scsi@vger.kernel.org>,
Brian Silverman <bsilver16384@gmail.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
gregkh@linuxfoundation.org,
"open list:ULTRA-WIDEBAND UWB SUBSYSTEM:"
<linux-usb@vger.kernel.org>,
"open list:NETWORKING DRIVERS WIRELESS"
<linux-wireless@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>,
Sesidhar Baddela <sebaddel@cisco.com>,
open list <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"open list:AMD IOMMU AMD-VI" <iommu@lists.linux-foundation.org>,
"open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER"
<ath9k-devel@lists.ath9k.org>, Rafael Wysocki <rjw@rjwysocki.net>,
Narsimhulu Musini <nmusini@cisco.com>,
Wang Long <long.wanglong@huawei.com>, Tejun Heo <tj@kernel.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Len Brown <lenb@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
"open list:CXGB4 ETHERNET DRIVER CXGB4" <netdev@vger.kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Mon, 14 Sep 2015 21:17:08 +0530 [thread overview]
Message-ID: <20150914154708.GF32551@linux> (raw)
In-Reply-To: <1708603.aKpYchk1pa@wuerfel>
On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
> > goto error;
> >
> > if (write_support)
>
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.
Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?
Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.
@Greg: What all kernel versions you want this to be backported for?
--
viresh
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Mon, 14 Sep 2015 15:47:35 -0000 [thread overview]
Message-ID: <20150914154708.GF32551@linux> (raw)
In-Reply-To: <1708603.aKpYchk1pa@wuerfel>
On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
> > goto error;
> >
> > if (write_support)
>
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.
Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?
Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.
@Greg: What all kernel versions you want this to be backported for?
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org, gregkh@linuxfoundation.org,
"open list:NETWORKING DRIVERS WIRELESS"
<linux-wireless@vger.kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Avri Altman <avri.altman@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Jiri Slaby <jirislaby@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Wang Long <long.wanglong@huawei.com>,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Ingo Molnar <mingo@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Joonsoo Kim <js1304@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
Joerg Roedel <joro@8bytes.org>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@opensource.wolfsonmicro.com>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists.infradead.org>,
Intel Linux Wireless <ilw@linux.intel.com>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER"
<ath9k-devel@lists.ath9k.org>,
Nick Kossifidis <mickflemm@gmail.com>,
"open list:B43 WIRELESS DRIVER" <b43-dev@lists.infradead.org>,
Luciano Coelho <luciano.coelho@intel.com>,
Doug Thompson <dougthompson@xmission.com>,
Gustavo Padovan <gustavo@padovan.org>,
Sasha Levin <sasha.levin@oracle.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
sboyd@codeaurora.org, Len Brown <lenb@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Hariprasad S <hariprasad@chelsio.com>,
Johannes Berg <johannes.berg@intel.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Vlastimil Babka <vbabka@suse.cz>, Arik Nemtsov <arik@wizery.com>,
Marcel Holtmann <marcel@holtmann.org>,
David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Tejun Heo <tj@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Borislav Petkov <bp@alien8.de>, Oleg Nesterov <oleg@redhat.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Mel Gorman <mgorman@suse.de>,
"moderated list:ARM64 PORT AARCH64 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
Haggai Eran <haggaie@mellanox.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
Chaya Rachel Ivgi <chaya.rachel.ivgi@intel.com>,
"open list:CISCO SCSI HBA DRIVER" <linux-scsi@vger.kernel.org>,
Brian Silverman <bsilver16384@gmail.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
"open list:CXGB4 ETHERNET DRIVER CXGB4" <netdev@vger.kernel.org>,
"open list:ULTRA-WIDEBAND UWB SUBSYSTEM:"
<linux-usb@vger.kernel.org>, Rafael Wysocki <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Sesidhar Baddela <sebaddel@cisco.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"open list:AMD IOMMU AMD-VI" <iommu@lists.linux-foundation.org>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Thomas Gleixner <tglx@linutronix.de>,
Narsimhulu Musini <nmusini@cisco.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joe Perches <joe@perches.com>, Eliad Peller <eliad@wizery.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Mon, 14 Sep 2015 21:17:08 +0530 [thread overview]
Message-ID: <20150914154708.GF32551@linux> (raw)
In-Reply-To: <1708603.aKpYchk1pa@wuerfel>
On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
> > goto error;
> >
> > if (write_support)
>
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.
Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?
Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.
@Greg: What all kernel versions you want this to be backported for?
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org, gregkh@linuxfoundation.org,
"open list:NETWORKING DRIVERS WIRELESS"
<linux-wireless@vger.kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Avri Altman <avri.altman@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Jiri Slaby <jirislaby@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Wang Long <long.wanglong@huawei.com>,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Ingo Molnar <mingo@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Joonsoo Kim <js1304@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
Joerg Roedel <joro@8bytes.org>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@opensource.wolfsonmicro.com>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists.infradead.org>,
Intel Linux Wireless <ilw@linux.intel.com>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER"
<ath9k-devel@lists.ath9k.org>,
Nick Kossifidis <mickflemm@gmail.com>,
"open list:B43 WIRELESS DRIVER" <b43-dev@lists.infradead.org>,
Luciano Coelho <luciano.coelho@intel.com>,
Doug Thompson <dougthompson@xmission.com>,
Gustavo Padovan <gustavo@padovan.org>,
Sasha Levin <sasha.levin@oracle.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
sboyd@codeaurora.org, Len Brown <lenb@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Hariprasad S <hariprasad@chelsio.com>,
Johannes Berg <johannes.berg@intel.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Vlastimil Babka <vbabka@suse.cz>, Arik Nemtsov <arik@wizery.com>,
Marcel Holtmann <marcel@holtmann.org>,
David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Tejun Heo <tj@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Borislav Petkov <bp@alien8.de>, Oleg Nesterov <oleg@redhat.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Mel Gorman <mgorman@suse.de>,
"moderated list:ARM64 PORT AARCH64 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
Haggai Eran <haggaie@mellanox.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
Chaya Rachel Ivgi <chaya.rachel.ivgi@intel.com>,
"open list:CISCO SCSI HBA DRIVER" <linux-scsi@vger.kernel.org>,
Brian Silverman <bsilver16384@gmail.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
"open list:CXGB4 ETHERNET DRIVER CXGB4" <netdev@vger.kernel.org>,
"open list:ULTRA-WIDEBAND UWB SUBSYSTEM:"
<linux-usb@vger.kernel.org>, Rafael Wysocki <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Sesidhar Baddela <sebaddel@cisco.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"open list:AMD IOMMU AMD-VI" <iommu@lists.linux-foundation.org>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Thomas Gleixner <tglx@linutronix.de>,
Narsimhulu Musini <nmusini@cisco.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joe Perches <joe@perches.com>, Eliad Peller <eliad@wizery.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Mon, 14 Sep 2015 21:17:08 +0530 [thread overview]
Message-ID: <20150914154708.GF32551@linux> (raw)
In-Reply-To: <1708603.aKpYchk1pa@wuerfel>
On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
> > goto error;
> >
> > if (write_support)
>
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.
Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?
Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.
@Greg: What all kernel versions you want this to be backported for?
--
viresh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org, gregkh@linuxfoundation.org,
"open list:NETWORKING DRIVERS WIRELESS"
<linux-wireless@vger.kernel.org>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Avri Altman <avri.altman@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Jiri Slaby <jirislaby@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Wang Long <long.wanglong@huawei.com>,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Ingo Molnar <mingo@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Davidlohr Bueso <dave@stgola
Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Mon, 14 Sep 2015 21:17:08 +0530 [thread overview]
Message-ID: <20150914154708.GF32551@linux> (raw)
In-Reply-To: <1708603.aKpYchk1pa@wuerfel>
On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
> > goto error;
> >
> > if (write_support)
>
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.
Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?
Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.
@Greg: What all kernel versions you want this to be backported for?
--
viresh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-14 15:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 3:51 [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes Viresh Kumar
2015-09-14 4:00 ` [ath9k-devel] " Viresh Kumar
2015-09-14 3:51 ` Viresh Kumar
2015-09-14 3:51 ` Viresh Kumar
2015-09-14 3:51 ` Viresh Kumar
2015-09-14 3:51 ` Viresh Kumar
[not found] ` <81516fb9c662cc338b5af5b63fbbcde5374e0893.1442202447.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-14 15:39 ` Arnd Bergmann
2015-09-14 15:52 ` [ath9k-devel] " Arnd Bergmann
2015-09-14 15:39 ` Arnd Bergmann
2015-09-14 15:39 ` Arnd Bergmann
2015-09-14 15:39 ` Arnd Bergmann
2015-09-14 15:39 ` Arnd Bergmann
2015-09-14 15:47 ` Viresh Kumar [this message]
2015-09-14 15:47 ` [ath9k-devel] " Viresh Kumar
2015-09-14 15:47 ` Viresh Kumar
2015-09-14 15:47 ` Viresh Kumar
2015-09-14 15:47 ` Viresh Kumar
2015-09-14 15:47 ` Viresh Kumar
2015-09-14 16:03 ` Greg KH
2015-09-14 16:13 ` [ath9k-devel] " Greg KH
2015-09-14 16:03 ` Greg KH
2015-09-14 16:03 ` Greg KH
2015-09-14 16:03 ` Greg KH
2015-09-14 16:03 ` Greg KH
2015-09-15 2:04 ` Viresh Kumar
2015-09-15 2:04 ` [ath9k-devel] " Viresh Kumar
2015-09-15 2:04 ` Viresh Kumar
2015-09-15 2:04 ` Viresh Kumar
2015-09-15 2:04 ` Viresh Kumar
2015-09-15 2:04 ` Viresh Kumar
2015-09-15 6:30 ` Arnd Bergmann
2015-09-15 6:34 ` [ath9k-devel] " Arnd Bergmann
2015-09-15 6:30 ` Arnd Bergmann
2015-09-15 6:30 ` Arnd Bergmann
2015-09-15 6:30 ` Arnd Bergmann
2015-09-15 6:30 ` Arnd Bergmann
2015-09-14 17:11 ` Mark Brown
2015-09-14 17:45 ` [ath9k-devel] " Mark Brown
2015-09-14 17:11 ` Mark Brown
2015-09-14 17:11 ` Mark Brown
2015-09-14 17:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914154708.GF32551@linux \
--to=viresh.kumar@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=avri.altman@intel.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave@stgola \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-wireless@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mingo@kernel.org \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rf@opensource.wolfsonmicro.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.