From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Will Deacon <will.deacon@arm.com>,
hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
mingo@elte.hu, minchan@kernel.org, tglx@linutronix.de,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set")
Date: Mon, 14 Sep 2015 19:05:47 +0200 [thread overview]
Message-ID: <20150914170547.GA28535@redhat.com> (raw)
In-Reply-To: <20150914115800.06242CE@black.fi.intel.com>
On 09/14, Kirill A. Shutemov wrote:
>
> Fix is below. I don't really like it, but I cannot find any better
> solution.
Me too...
But this change "documents" the nasty special "vm_file && !vm_ops" case, and
I am not sure how we can remove it later...
So perhaps we should change vma_is_anonymous() back to check ->fault too,
static inline bool vma_is_anonymous(struct vm_area_struct *vma)
{
- return !vma->vm_ops;
+ return !vma->vm_ops || !vma->vm_ops->fault;
}
and remove the "vma->vm_file && !vma->vm_ops" checks in mmap_region() paths.
I dunno.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Will Deacon <will.deacon@arm.com>,
hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
mingo@elte.hu, minchan@kernel.org, tglx@linutronix.de,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set")
Date: Mon, 14 Sep 2015 19:05:47 +0200 [thread overview]
Message-ID: <20150914170547.GA28535@redhat.com> (raw)
In-Reply-To: <20150914115800.06242CE@black.fi.intel.com>
On 09/14, Kirill A. Shutemov wrote:
>
> Fix is below. I don't really like it, but I cannot find any better
> solution.
Me too...
But this change "documents" the nasty special "vm_file && !vm_ops" case, and
I am not sure how we can remove it later...
So perhaps we should change vma_is_anonymous() back to check ->fault too,
static inline bool vma_is_anonymous(struct vm_area_struct *vma)
{
- return !vma->vm_ops;
+ return !vma->vm_ops || !vma->vm_ops->fault;
}
and remove the "vma->vm_file && !vma->vm_ops" checks in mmap_region() paths.
I dunno.
Oleg.
next prev parent reply other threads:[~2015-09-14 17:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 10:53 LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set") Will Deacon
2015-09-14 10:53 ` Will Deacon
2015-09-14 11:57 ` Kirill A. Shutemov
2015-09-14 11:57 ` Kirill A. Shutemov
2015-09-14 13:22 ` Will Deacon
2015-09-14 13:22 ` Will Deacon
2015-09-14 17:05 ` Oleg Nesterov [this message]
2015-09-14 17:05 ` Oleg Nesterov
2015-09-14 17:46 ` Oleg Nesterov
2015-09-14 17:46 ` Oleg Nesterov
2015-09-14 18:20 ` Kirill A. Shutemov
2015-09-14 18:20 ` Kirill A. Shutemov
2015-09-15 12:12 ` Oleg Nesterov
2015-09-15 12:12 ` Oleg Nesterov
2015-09-15 13:42 ` Kirill A. Shutemov
2015-09-15 13:42 ` Kirill A. Shutemov
2015-09-15 15:13 ` Oleg Nesterov
2015-09-15 15:13 ` Oleg Nesterov
2015-09-16 21:28 ` Andrew Morton
2015-09-16 21:28 ` Andrew Morton
2015-09-17 15:37 ` Kirill A. Shutemov
2015-09-17 15:37 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914170547.GA28535@redhat.com \
--to=oleg@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.