All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Cho <tony.cho@atmel.com>
Cc: devel@driverdev.osuosl.org, rachel.kim@atmel.com,
	chris.park@atmel.com, austin.shin@atmel.com,
	linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
	Nicolas.FERRE@atmel.com, adel.noureldin@atmel.com,
	leo.kim@atmel.com, adham.abozaeid@atmel.com
Subject: Re: [PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK
Date: Tue, 15 Sep 2015 06:45:07 -0700	[thread overview]
Message-ID: <20150915134507.GA22620@kroah.com> (raw)
In-Reply-To: <1442285621-29457-3-git-send-email-tony.cho@atmel.com>

On Tue, Sep 15, 2015 at 11:53:36AM +0900, Tony Cho wrote:
> From: Leo Kim <leo.kim@atmel.com>
> 
> This patch removes the definition WILC_NULLCHECK which is not used anymore.

No, it is used, you just remove all usages of it in this patch as well
:)

Also, your fixes are not correct, you are not keeping the same codepaths
here anymore, you are returning and not jumping to the ERRORHANDLER: tag
anymore, which could mean you are leaking memory.  Please fix up this
series and resend, but note, I took the first patch here.

thanks,

greg k-h

  reply	other threads:[~2015-09-15 13:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  2:53 [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver Tony Cho
2015-09-15  2:53 ` [PATCH 1/7] staging: wilc1000: remove definition WILC_IS_ERR Tony Cho
2015-09-15  2:53 ` [PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK Tony Cho
2015-09-15 13:45   ` Greg KH [this message]
2015-09-15  2:53 ` [PATCH 3/7] staging: wilc1000: remove definition WILC_ERRORCHECK Tony Cho
2015-09-15  2:53 ` [PATCH 4/7] staging: wilc1000: remove definition WILC_ERRORREPORT Tony Cho
2015-09-15  2:53 ` [PATCH 5/7] staging: wilc1000: remove definitions unused Tony Cho
2015-09-15  2:53 ` [PATCH 6/7] staging: wilc1000: replace wilc error types with kernel generic error type Tony Cho
2015-09-15  2:53 ` [PATCH 7/7] staging: wilc1000: remove wilc_errorsupport Tony Cho
2015-09-15  6:27 ` [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver Sudip Mukherjee
2015-09-15  6:50   ` Tony Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150915134507.GA22620@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=adel.noureldin@atmel.com \
    --cc=adham.abozaeid@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.