All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Cho <tony.cho@atmel.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <devel@driverdev.osuosl.org>,
	<rachel.kim@atmel.com>, <chris.park@atmel.com>,
	<austin.shin@atmel.com>, <linux-wireless@vger.kernel.org>,
	<johnny.kim@atmel.com>, <Nicolas.FERRE@atmel.com>,
	<adel.noureldin@atmel.com>, <leo.kim@atmel.com>,
	<adham.abozaeid@atmel.com>
Subject: Re: [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver
Date: Tue, 15 Sep 2015 15:50:02 +0900	[thread overview]
Message-ID: <55F7BF9A.6070600@atmel.com> (raw)
In-Reply-To: <20150915062715.GG12611@sudip-pc>



On 2015년 09월 15일 15:27, Sudip Mukherjee wrote:
> On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote:
>> This patch aims to remove the wilc_errorsupport.h which is unnecessary in the
>> wilc driver. This patch replaces the error types defined by wilc driver with
>> kernel generic error types and removes macros which handles the errors.
> Patch 2/7 and 4/7 are introducing new checkpatch warnings which again
> some has to fix in a separate patch. Better to fix it while you are
> sending. And instead of printk it should be pr_err or much better if you
> can use netev_err. Looks like it can be used in some of the functions.
>
> regards
> sudip

I will check patch warnings and resend v2. I'm designing new debug functions and it will be
introduced in the next patch.

Thanks for your advice,
Tony.



      reply	other threads:[~2015-09-15  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  2:53 [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver Tony Cho
2015-09-15  2:53 ` [PATCH 1/7] staging: wilc1000: remove definition WILC_IS_ERR Tony Cho
2015-09-15  2:53 ` [PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK Tony Cho
2015-09-15 13:45   ` Greg KH
2015-09-15  2:53 ` [PATCH 3/7] staging: wilc1000: remove definition WILC_ERRORCHECK Tony Cho
2015-09-15  2:53 ` [PATCH 4/7] staging: wilc1000: remove definition WILC_ERRORREPORT Tony Cho
2015-09-15  2:53 ` [PATCH 5/7] staging: wilc1000: remove definitions unused Tony Cho
2015-09-15  2:53 ` [PATCH 6/7] staging: wilc1000: replace wilc error types with kernel generic error type Tony Cho
2015-09-15  2:53 ` [PATCH 7/7] staging: wilc1000: remove wilc_errorsupport Tony Cho
2015-09-15  6:27 ` [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver Sudip Mukherjee
2015-09-15  6:50   ` Tony Cho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F7BF9A.6070600@atmel.com \
    --to=tony.cho@atmel.com \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=adel.noureldin@atmel.com \
    --cc=adham.abozaeid@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.