All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb
Date: Wed, 16 Sep 2015 10:31:10 +0800	[thread overview]
Message-ID: <20150916023109.GB15736@shlinux2> (raw)
In-Reply-To: <CAOMZO5AJPF2JtuxsRv4xbNPeyp18hNT0MMZbXODBoQmYVPARuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, Sep 16, 2015 at 12:25:17AM -0300, Fabio Estevam wrote:
> On Tue, Sep 15, 2015 at 10:49 PM, Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:
> > For imx27, it needs three clocks to let the controller work,
> > the old code is wrong, and will cause below data abort when
> > accass usbmisc registers.
> >
> > usbcore: registered new interface driver usb-storage
> > Unhandled fault: external abort on non-linefetch (0x008) at 0xf4424600
> > pgd = c0004000
> > [f4424600] *pgd=10000452(bad)
> > Internal error: : 8 [#1] PREEMPT ARM
> > Modules linked in:
> > CPU: 0 PID: 1 Comm: swapper Not tainted 4.1.0-next-20150701-dirty #3089
> > Hardware name: Freescale i.MX27 (Device Tree Support)
> > task: c7832b60 ti: c783e000 task.ti: c783e000
> > PC is at usbmisc_imx27_init+0x4c/0xbc
> > LR is at usbmisc_imx27_init+0x40/0xbc
> > pc : [<c03cb5c0>]    lr : [<c03cb5b4>]    psr: 60000093
> > sp : c783fe08  ip : 00000000  fp : 00000000
> > r10: c0576434  r9 : 0000009c  r8 : c7a773a0
> > r7 : 01000000  r6 : 60000013  r5 : c7a776f0  r4 : c7a773f0
> > r3 : f4424600  r2 : 00000000  r1 : 00000001  r0 : 00000001
> > Flags: nZCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
> > Control: 0005317f  Table: a0004000  DAC: 00000017
> > Process swapper (pid: 1, stack limit = 0xc783e190)
> > Stack: (0xc783fe08 to 0xc7840000)
> >
> > Signed-off-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Reported-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++----
> >  1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index feb9d34..93e3e14 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> 
> mx25.dtsi and mx35.dtsi also need to be changed.
> 

If you can help to test, I will update.

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	USB list <linux-usb@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb
Date: Wed, 16 Sep 2015 10:31:10 +0800	[thread overview]
Message-ID: <20150916023109.GB15736@shlinux2> (raw)
In-Reply-To: <CAOMZO5AJPF2JtuxsRv4xbNPeyp18hNT0MMZbXODBoQmYVPARuQ@mail.gmail.com>

On Wed, Sep 16, 2015 at 12:25:17AM -0300, Fabio Estevam wrote:
> On Tue, Sep 15, 2015 at 10:49 PM, Peter Chen <peter.chen@freescale.com> wrote:
> > For imx27, it needs three clocks to let the controller work,
> > the old code is wrong, and will cause below data abort when
> > accass usbmisc registers.
> >
> > usbcore: registered new interface driver usb-storage
> > Unhandled fault: external abort on non-linefetch (0x008) at 0xf4424600
> > pgd = c0004000
> > [f4424600] *pgd=10000452(bad)
> > Internal error: : 8 [#1] PREEMPT ARM
> > Modules linked in:
> > CPU: 0 PID: 1 Comm: swapper Not tainted 4.1.0-next-20150701-dirty #3089
> > Hardware name: Freescale i.MX27 (Device Tree Support)
> > task: c7832b60 ti: c783e000 task.ti: c783e000
> > PC is at usbmisc_imx27_init+0x4c/0xbc
> > LR is at usbmisc_imx27_init+0x40/0xbc
> > pc : [<c03cb5c0>]    lr : [<c03cb5b4>]    psr: 60000093
> > sp : c783fe08  ip : 00000000  fp : 00000000
> > r10: c0576434  r9 : 0000009c  r8 : c7a773a0
> > r7 : 01000000  r6 : 60000013  r5 : c7a776f0  r4 : c7a773f0
> > r3 : f4424600  r2 : 00000000  r1 : 00000001  r0 : 00000001
> > Flags: nZCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
> > Control: 0005317f  Table: a0004000  DAC: 00000017
> > Process swapper (pid: 1, stack limit = 0xc783e190)
> > Stack: (0xc783fe08 to 0xc7840000)
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: <stable@vger.kernel.org>
> > ---
> >  arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++----
> >  1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index feb9d34..93e3e14 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> 
> mx25.dtsi and mx35.dtsi also need to be changed.
> 

If you can help to test, I will update.

-- 

Best Regards,
Peter Chen

  parent reply	other threads:[~2015-09-16  2:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  1:49 [PATCH 1/4] doc: dt-binding: ci-hdrc-usb2: split vendor specific properties Peter Chen
     [not found] ` <1442368183-8103-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-09-16  1:49   ` [PATCH 2/4] doc: dt-binding: ci-hdrc-usb2: add i.mx specific binding "need-three-clocks" Peter Chen
     [not found]     ` <1442368183-8103-2-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-09-16  3:23       ` Fabio Estevam
     [not found]         ` <CAOMZO5Aj_Txbg-nNH_xoAd=eCW9yfP6GMEE=H8jKvuoH9=e-ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-16  2:24           ` Peter Chen
2015-09-16  3:42             ` Fabio Estevam
2015-09-16 13:54       ` Rob Herring
     [not found]         ` <55F97491.5060105-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-18  2:35           ` Peter Chen
2015-09-23 16:09             ` Rob Herring
2015-09-16  1:49   ` [PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb Peter Chen
2015-09-16  1:49     ` Peter Chen
2015-09-16  3:25     ` Fabio Estevam
     [not found]       ` <CAOMZO5AJPF2JtuxsRv4xbNPeyp18hNT0MMZbXODBoQmYVPARuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-16  2:31         ` Peter Chen [this message]
2015-09-16  2:31           ` Peter Chen
2015-09-16  3:46           ` Fabio Estevam
2015-09-16  3:46             ` Fabio Estevam
2015-09-16  4:55     ` Fabio Estevam
2015-09-16  1:49   ` [PATCH 4/4] usb: chipidea: imx: refine clock operations to adapt for all platforms Peter Chen
     [not found]     ` <1442368183-8103-4-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-09-16  3:43       ` Fabio Estevam
2015-09-16  4:57       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916023109.GB15736@shlinux2 \
    --to=peter.chen-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.