From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Stephen Boyd" <sboyd@codeaurora.org>,
"Andy Gross" <agross@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-soc@vger.kernel.org,
linux-mips@linux-mips.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
"Paul Walmsley" <paul@pwsan.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Bjorn Andersson" <bjorn.andersson@sonymobile.com>,
"Andi Kleen" <andi@firstfloor.org>
Subject: Re: [PATCH 0/3] Add __ioread32_copy() and use it
Date: Wed, 16 Sep 2015 04:32:19 +0200 [thread overview]
Message-ID: <20150916023219.GD1747@two.firstfloor.org> (raw)
In-Reply-To: <20150915155815.5a41a8dc537610ab44d8d3dc@linux-foundation.org>
> __iowrite32_copy() is marked __visible. I don't actually know what
> that does and Andi's d47d5c8194579bc changelog (which sucks the big
> one) didn't explain it. Apparently it has something to do with being
> implemented in assembly, but zillions of functions are implemented in
> assembly, so why are only two functions marked this way? Anyway,
> __ioread32_copy() is implemented in C so I guess __visible isn't needed
> there.
__visible is needed for C functions that are called from assembler.
Otherwise the compiler may optimize them away.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: andi@firstfloor.org (Andi Kleen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Add __ioread32_copy() and use it
Date: Wed, 16 Sep 2015 04:32:19 +0200 [thread overview]
Message-ID: <20150916023219.GD1747@two.firstfloor.org> (raw)
In-Reply-To: <20150915155815.5a41a8dc537610ab44d8d3dc@linux-foundation.org>
> __iowrite32_copy() is marked __visible. I don't actually know what
> that does and Andi's d47d5c8194579bc changelog (which sucks the big
> one) didn't explain it. Apparently it has something to do with being
> implemented in assembly, but zillions of functions are implemented in
> assembly, so why are only two functions marked this way? Anyway,
> __ioread32_copy() is implemented in C so I guess __visible isn't needed
> there.
__visible is needed for C functions that are called from assembler.
Otherwise the compiler may optimize them away.
-Andi
next prev parent reply other threads:[~2015-09-16 2:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 19:41 [PATCH 0/3] Add __ioread32_copy() and use it Stephen Boyd
2015-09-15 19:41 ` Stephen Boyd
2015-09-15 19:41 ` [PATCH 1/3] lib: iomap_copy: Add __ioread32_copy() Stephen Boyd
2015-09-15 19:41 ` Stephen Boyd
2015-09-15 19:41 ` [PATCH 2/3] soc: qcom: smd: Use __ioread32_copy() instead of open-coding it Stephen Boyd
2015-09-15 19:41 ` Stephen Boyd
2015-09-15 19:41 ` [PATCH 3/3] FIRMWARE: bcm47xx_nvram: Use __ioread32_copy() instead of open-coding Stephen Boyd
2015-09-15 19:41 ` Stephen Boyd
2015-09-15 22:58 ` [PATCH 0/3] Add __ioread32_copy() and use it Andrew Morton
2015-09-15 22:58 ` Andrew Morton
2015-09-16 0:50 ` Stephen Boyd
2015-09-16 0:50 ` Stephen Boyd
2015-09-16 22:09 ` Andrew Morton
2015-09-16 22:09 ` Andrew Morton
2015-09-16 2:32 ` Andi Kleen [this message]
2015-09-16 2:32 ` Andi Kleen
2015-09-16 2:50 ` Andrew Morton
2015-09-16 2:50 ` Andrew Morton
2015-09-16 2:55 ` Andi Kleen
2015-09-16 2:55 ` Andi Kleen
2015-09-18 19:19 ` Andrew Morton
2015-09-18 19:19 ` Andrew Morton
2015-09-19 20:16 ` Andi Kleen
2015-09-19 20:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916023219.GD1747@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=agross@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-soc@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sboyd@codeaurora.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.