From: Stephen Boyd <sboyd@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
rui.zhang@intel.com, edubezval@gmail.com,
srinivas.kandagatla@linaro.org, nrajan@codeaurora.org,
lina.iyer@linaro.org
Subject: Re: [PATCH v2 4/9] clk: qcom: create virtual child device for TSENS
Date: Wed, 16 Sep 2015 15:39:25 -0700 [thread overview]
Message-ID: <20150916223925.GP23081@codeaurora.org> (raw)
In-Reply-To: <1442384603-26053-5-git-send-email-rnayak@codeaurora.org>
On 09/16, Rajendra Nayak wrote:
> @@ -3520,7 +3522,26 @@ static int gcc_msm8960_probe(struct platform_device *pdev)
> if (IS_ERR(clk))
> return PTR_ERR(clk);
>
> - return qcom_cc_probe(pdev, match->data);
> + ret = qcom_cc_probe(pdev, match->data);
> + if (ret)
> + return ret;
> +
> + tsens = platform_device_alloc("qcom-tsens", -1);
> + if (!tsens) {
> + ret = -ENOMEM;
> + goto err_alloc;
> + }
> +
> + tsens->dev.parent = &pdev->dev;
> + ret = platform_device_add(tsens);
> + if (ret)
> + goto err_add;
platform_device_register_data() instead of all these lines? We
should probably remove the device when this driver is removed
too.
> + return 0;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/9] clk: qcom: create virtual child device for TSENS
Date: Wed, 16 Sep 2015 15:39:25 -0700 [thread overview]
Message-ID: <20150916223925.GP23081@codeaurora.org> (raw)
In-Reply-To: <1442384603-26053-5-git-send-email-rnayak@codeaurora.org>
On 09/16, Rajendra Nayak wrote:
> @@ -3520,7 +3522,26 @@ static int gcc_msm8960_probe(struct platform_device *pdev)
> if (IS_ERR(clk))
> return PTR_ERR(clk);
>
> - return qcom_cc_probe(pdev, match->data);
> + ret = qcom_cc_probe(pdev, match->data);
> + if (ret)
> + return ret;
> +
> + tsens = platform_device_alloc("qcom-tsens", -1);
> + if (!tsens) {
> + ret = -ENOMEM;
> + goto err_alloc;
> + }
> +
> + tsens->dev.parent = &pdev->dev;
> + ret = platform_device_add(tsens);
> + if (ret)
> + goto err_add;
platform_device_register_data() instead of all these lines? We
should probably remove the device when this driver is removed
too.
> + return 0;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-09-16 22:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 6:23 [PATCH v2 0/9] qcom: Add support for TSENS driver Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 1/9] thermal: qcom: tsens: Add a skeletal TSENS drivers Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 13:44 ` Punit Agrawal
2015-09-16 13:44 ` Punit Agrawal
2015-09-21 4:26 ` Rajendra Nayak
2015-09-21 4:26 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 2/9] thermal: qcom: tsens-8916: Add support for 8916 family of SoCs Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 13:46 ` Punit Agrawal
2015-09-16 13:46 ` Punit Agrawal
2015-09-21 4:28 ` Rajendra Nayak
2015-09-21 4:28 ` Rajendra Nayak
2015-10-08 5:05 ` Rajendra Nayak
2015-10-08 5:05 ` Rajendra Nayak
2015-10-08 14:32 ` Punit Agrawal
2015-10-08 14:32 ` Punit Agrawal
2015-09-16 6:23 ` [PATCH v2 3/9] thermal: qcom: tsens-8974: Add support for 8974 " Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 4/9] clk: qcom: create virtual child device for TSENS Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 22:39 ` Stephen Boyd [this message]
2015-09-16 22:39 ` Stephen Boyd
2015-09-21 4:28 ` Rajendra Nayak
2015-09-21 4:28 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 5/9] thermal: qcom: tsens-8960: Add support for 8960 family of SoCs Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 6/9] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 7/9] arm: dts: apq8064: " Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 8/9] arm: dts: apq8084: " Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
2015-09-16 6:23 ` [PATCH v2 9/9] arm64: dts: msm8916: " Rajendra Nayak
2015-09-16 6:23 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916223925.GP23081@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=edubezval@gmail.com \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nrajan@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.