From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC
Date: Thu, 17 Sep 2015 13:29:05 +0200 [thread overview]
Message-ID: <20150917112905.GC4684@lukather> (raw)
In-Reply-To: <1442325957-10102-3-git-send-email-yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Hi Yassin,
On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Yassin Jaffer <yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Add Keypad controller node definition to the A20 SoC.
>
> Signed-off-by: Yassin Jaffer <yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 333604a..35cc8d0 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1198,6 +1198,15 @@
> status = "disabled";
> };
>
> + kp: kp@01c23000 {
The node name should reflect the class of the device. keypad@01c23000
would be better for example.
It looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC
Date: Thu, 17 Sep 2015 13:29:05 +0200 [thread overview]
Message-ID: <20150917112905.GC4684@lukather> (raw)
In-Reply-To: <1442325957-10102-3-git-send-email-yassinjaffer@gmail.com>
Hi Yassin,
On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer at gmail.com wrote:
> From: Yassin Jaffer <yassinjaffer@gmail.com>
>
> Add Keypad controller node definition to the A20 SoC.
>
> Signed-off-by: Yassin Jaffer <yassinjaffer@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 333604a..35cc8d0 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1198,6 +1198,15 @@
> status = "disabled";
> };
>
> + kp: kp at 01c23000 {
The node name should reflect the class of the device. keypad at 01c23000
would be better for example.
It looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150917/5e4505a3/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: yassinjaffer@gmail.com
Cc: linux-sunxi@googlegroups.com, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC
Date: Thu, 17 Sep 2015 13:29:05 +0200 [thread overview]
Message-ID: <20150917112905.GC4684@lukather> (raw)
In-Reply-To: <1442325957-10102-3-git-send-email-yassinjaffer@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
Hi Yassin,
On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@gmail.com wrote:
> From: Yassin Jaffer <yassinjaffer@gmail.com>
>
> Add Keypad controller node definition to the A20 SoC.
>
> Signed-off-by: Yassin Jaffer <yassinjaffer@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 333604a..35cc8d0 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1198,6 +1198,15 @@
> status = "disabled";
> };
>
> + kp: kp@01c23000 {
The node name should reflect the class of the device. keypad@01c23000
would be better for example.
It looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-17 11:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 14:05 NEW SUN4i KEYPAD DRIVER yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w
2015-09-15 14:05 ` yassinjaffer
2015-09-15 14:05 ` yassinjaffer at gmail.com
2015-09-15 14:05 ` [PATCH 1/4] ARM:dts:sun7i: Add keypad clk node yassinjaffer
2015-09-15 14:05 ` yassinjaffer at gmail.com
2015-09-16 5:11 ` Maxime Ripard
2015-09-16 5:11 ` Maxime Ripard
[not found] ` <1442325957-10102-1-git-send-email-yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-15 14:05 ` [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w
2015-09-15 14:05 ` yassinjaffer
2015-09-15 14:05 ` yassinjaffer at gmail.com
[not found] ` <1442325957-10102-3-git-send-email-yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-17 11:29 ` Maxime Ripard [this message]
2015-09-17 11:29 ` Maxime Ripard
2015-09-17 11:29 ` Maxime Ripard
2015-09-17 14:20 ` Chen-Yu Tsai
2015-09-17 14:20 ` [linux-sunxi] " Chen-Yu Tsai
2015-09-17 14:20 ` Chen-Yu Tsai
2015-09-15 14:05 ` [PATCH 3/4] input: Add new sun4i-keypad driver yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w
2015-09-15 14:05 ` yassinjaffer
2015-09-15 14:05 ` yassinjaffer at gmail.com
[not found] ` <1442325957-10102-4-git-send-email-yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-17 13:05 ` Maxime Ripard
2015-09-17 13:05 ` Maxime Ripard
2015-09-17 13:05 ` Maxime Ripard
2015-09-18 0:19 ` Yassin Jaffer
[not found] ` <CAJzetvvUscEgTQ0Sr-BF7D6rzN_bfWT1KikRqz+BvSV-2+TWrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-18 9:44 ` Maxime Ripard
2015-09-18 9:44 ` Maxime Ripard
2015-09-18 9:44 ` Maxime Ripard
2015-09-21 17:19 ` Dmitry Torokhov
2015-09-21 17:19 ` Dmitry Torokhov
2015-09-21 17:19 ` Dmitry Torokhov
2015-09-15 14:05 ` [PATCH 4/4] devicetree: bindings:Allwinner sun4i keypad yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w
2015-09-15 14:05 ` yassinjaffer
2015-09-15 14:05 ` yassinjaffer at gmail.com
[not found] ` <1442325957-10102-5-git-send-email-yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-15 15:30 ` Maxime Ripard
2015-09-15 15:30 ` Maxime Ripard
2015-09-15 15:30 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917112905.GC4684@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.