From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>,
Grazvydas Ignotas <notasas@gmail.com>,
Benoit Cousson <bcousson@baylibre.com>,
Sourav Poddar <sourav.poddar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm
Date: Fri, 18 Sep 2015 10:48:36 -0700 [thread overview]
Message-ID: <20150918174836.GG8020@atomide.com> (raw)
In-Reply-To: <CABxcv=mGNmoVu3TDvd1888TiJ_vg0FJF6qz0p4XTu5T776sJ2Q@mail.gmail.com>
* Javier Martinez Canillas <javier@dowhile0.org> [150918 10:39]:
> Hello Tony,
>
> [snip]
>
> >
> > + vmmcsdio_fixed: fixedregulator-mmcsdio {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vmmcsdio_fixed";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + gpio = <&gpio5 12 GPIO_ACTIVE_HIGH>; /* gpio140 WLAN_EN */
>
> I know that other OMAP boards use a fake fixed regulator to toggle the
> WiFi enable pin but now the MMC subsystem has proper support for power
> sequence providers so that should be used instead. For simple uses
> like this, Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt
> should be enough.
Hmm OK great, I'll take a look. Looks like that might also provide a
nice solution for handling the 32k clock from palmas to the wl12xx.
In the wl12xx case it's a real regulator on wl12xx though, not a fake.
It gets the power directly from VBAT and generates it's own clocks..
Of course nobody knows what the chip is actually doing with the GPIO
pin, it's probably just a hint to some wl12xx internal state machine.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm
Date: Fri, 18 Sep 2015 10:48:36 -0700 [thread overview]
Message-ID: <20150918174836.GG8020@atomide.com> (raw)
In-Reply-To: <CABxcv=mGNmoVu3TDvd1888TiJ_vg0FJF6qz0p4XTu5T776sJ2Q@mail.gmail.com>
* Javier Martinez Canillas <javier@dowhile0.org> [150918 10:39]:
> Hello Tony,
>
> [snip]
>
> >
> > + vmmcsdio_fixed: fixedregulator-mmcsdio {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vmmcsdio_fixed";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + gpio = <&gpio5 12 GPIO_ACTIVE_HIGH>; /* gpio140 WLAN_EN */
>
> I know that other OMAP boards use a fake fixed regulator to toggle the
> WiFi enable pin but now the MMC subsystem has proper support for power
> sequence providers so that should be used instead. For simple uses
> like this, Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt
> should be enough.
Hmm OK great, I'll take a look. Looks like that might also provide a
nice solution for handling the 32k clock from palmas to the wl12xx.
In the wl12xx case it's a real regulator on wl12xx though, not a fake.
It gets the power directly from VBAT and generates it's own clocks..
Of course nobody knows what the chip is actually doing with the GPIO
pin, it's probably just a hint to some wl12xx internal state machine.
Regards,
Tony
next prev parent reply other threads:[~2015-09-18 17:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 16:29 [PATCH 0/2] Fix omap5-uevm WLAN regressions Tony Lindgren
2015-09-18 16:29 ` Tony Lindgren
2015-09-18 16:29 ` [PATCH 1/2] mfd: twl6040: Fix deferred probe handling for clk32k Tony Lindgren
2015-09-18 16:29 ` Tony Lindgren
2015-09-18 16:40 ` Felipe Balbi
2015-09-18 16:40 ` Felipe Balbi
2015-09-19 9:57 ` Lee Jones
2015-09-19 9:57 ` Lee Jones
2015-09-21 9:55 ` Peter Ujfalusi
2015-09-21 9:55 ` Peter Ujfalusi
2015-09-21 13:59 ` Tony Lindgren
2015-09-21 13:59 ` Tony Lindgren
2015-09-18 16:29 ` [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm Tony Lindgren
2015-09-18 16:29 ` Tony Lindgren
2015-09-18 16:40 ` Robert Nelson
2015-09-18 16:40 ` Robert Nelson
2015-09-18 16:51 ` Tony Lindgren
2015-09-18 16:51 ` Tony Lindgren
2015-09-18 17:22 ` Tony Lindgren
2015-09-18 17:22 ` Tony Lindgren
2015-09-18 18:39 ` Robert Nelson
2015-09-18 18:39 ` Robert Nelson
2015-09-19 21:12 ` Grazvydas Ignotas
2015-09-19 21:12 ` Grazvydas Ignotas
2015-09-19 22:52 ` Tony Lindgren
2015-09-19 22:52 ` Tony Lindgren
2015-09-18 17:35 ` Javier Martinez Canillas
2015-09-18 17:35 ` Javier Martinez Canillas
2015-09-18 17:48 ` Tony Lindgren [this message]
2015-09-18 17:48 ` Tony Lindgren
2015-09-18 20:27 ` Tony Lindgren
2015-09-18 20:27 ` Tony Lindgren
2015-09-18 20:35 ` Tony Lindgren
2015-09-18 20:35 ` Tony Lindgren
2015-09-21 9:13 ` Javier Martinez Canillas
2015-09-21 9:13 ` Javier Martinez Canillas
2015-09-21 14:10 ` Tony Lindgren
2015-09-21 14:10 ` Tony Lindgren
2015-09-23 21:06 ` Tony Lindgren
2015-09-23 21:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918174836.GG8020@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=hns@goldelico.com \
--cc=javier@dowhile0.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.