From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: agraf@suse.de, kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org,
michael@ellerman.id.au, qemu-ppc@nongnu.org,
amit.shah@redhat.com, sam.bobroff@au1.ibm.com,
gkurz@linux.vnet.ibm.com
Subject: Re: [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU
Date: Mon, 21 Sep 2015 01:59:20 +0000 [thread overview]
Message-ID: <20150921015920.GH20331@voom.fritz.box> (raw)
In-Reply-To: <1442479781-20164-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
On Thu, Sep 17, 2015 at 10:49:41AM +0200, Thomas Huth wrote:
> The PAPR interface defines a hypercall to pass high-quality
> hardware generated random numbers to guests. Recent kernels can
> already provide this hypercall to the guest if the right hardware
> random number generator is available. But in case the user wants
> to use another source like EGD, or QEMU is running with an older
> kernel, we should also have this call in QEMU, so that guests that
> do not support virtio-rng yet can get good random numbers, too.
>
> This patch now adds a new pseudo-device to QEMU that either
> directly provides this hypercall to the guest or is able to
> enable the in-kernel hypercall if available. The in-kernel
> hypercall can be enabled with the use-kvm property, e.g.:
>
> qemu-system-ppc64 -device spapr-rng,use-kvm=true
>
> For handling the hypercall in QEMU instead, a "RngBackend" is
> required since the hypercall should provide "good" random data
> instead of pseudo-random (like from a "simple" library function
> like rand() or g_random_int()). Since there are multiple RngBackends
> available, the user must select an appropriate back-end via the
> "rng" property of the device, e.g.:
>
> qemu-system-ppc64 -object rng-random,filename=/dev/hwrng,id=gid0 \
> -device spapr-rng,rng=gid0 ...
>
> See http://wiki.qemu-project.org/Features-Done/VirtIORNG for
> other example of specifying RngBackends.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to spapr-next.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: agraf@suse.de, kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org,
michael@ellerman.id.au, qemu-ppc@nongnu.org,
amit.shah@redhat.com, sam.bobroff@au1.ibm.com,
gkurz@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU
Date: Mon, 21 Sep 2015 11:59:20 +1000 [thread overview]
Message-ID: <20150921015920.GH20331@voom.fritz.box> (raw)
In-Reply-To: <1442479781-20164-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
On Thu, Sep 17, 2015 at 10:49:41AM +0200, Thomas Huth wrote:
> The PAPR interface defines a hypercall to pass high-quality
> hardware generated random numbers to guests. Recent kernels can
> already provide this hypercall to the guest if the right hardware
> random number generator is available. But in case the user wants
> to use another source like EGD, or QEMU is running with an older
> kernel, we should also have this call in QEMU, so that guests that
> do not support virtio-rng yet can get good random numbers, too.
>
> This patch now adds a new pseudo-device to QEMU that either
> directly provides this hypercall to the guest or is able to
> enable the in-kernel hypercall if available. The in-kernel
> hypercall can be enabled with the use-kvm property, e.g.:
>
> qemu-system-ppc64 -device spapr-rng,use-kvm=true
>
> For handling the hypercall in QEMU instead, a "RngBackend" is
> required since the hypercall should provide "good" random data
> instead of pseudo-random (like from a "simple" library function
> like rand() or g_random_int()). Since there are multiple RngBackends
> available, the user must select an appropriate back-end via the
> "rng" property of the device, e.g.:
>
> qemu-system-ppc64 -object rng-random,filename=/dev/hwrng,id=gid0 \
> -device spapr-rng,rng=gid0 ...
>
> See http://wiki.qemu-project.org/Features-Done/VirtIORNG for
> other example of specifying RngBackends.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to spapr-next.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-21 1:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 8:49 [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU Thomas Huth
2015-09-17 8:49 ` [Qemu-devel] " Thomas Huth
2015-09-18 9:05 ` Greg Kurz
2015-09-18 9:05 ` [Qemu-devel] " Greg Kurz
2015-09-21 2:10 ` David Gibson
2015-09-21 2:10 ` [Qemu-devel] " David Gibson
2015-09-21 6:00 ` Thomas Huth
2015-09-21 6:00 ` [Qemu-devel] " Thomas Huth
2015-09-21 15:46 ` Eric Blake
2015-09-21 15:46 ` Eric Blake
2015-09-21 8:01 ` Greg Kurz
2015-09-21 8:01 ` [Qemu-devel] " Greg Kurz
2015-09-21 8:26 ` Thomas Huth
2015-09-21 8:26 ` Thomas Huth
2015-09-21 8:37 ` Greg Kurz
2015-09-21 8:37 ` Greg Kurz
2015-09-22 1:38 ` David Gibson
2015-09-22 1:38 ` David Gibson
2015-09-21 1:59 ` David Gibson [this message]
2015-09-21 1:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921015920.GH20331@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sam.bobroff@au1.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.