[PATCH] staging: skein: Add * on subsequent lines in block comment

[PATCH] staging: skein: Add * on subsequent lines in block comment

[Amber N. Adams]

This patch fixes the checkpatch.pl warning:

WARNING: Block comments use * on subsequent lines
+/*
+Copyright (c) 2010 Werner Dittmann

Signed-off-by: Amber N. Adams <amber@amberadams.co>
---
 drivers/staging/skein/skein_api.h | 48 +++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h
index 7da8b38..4cf7003 100644
--- a/drivers/staging/skein/skein_api.h
+++ b/drivers/staging/skein/skein_api.h
@@ -1,28 +1,28 @@
-/*
-Copyright (c) 2010 Werner Dittmann
-
-Permission is hereby granted, free of charge, to any person
-obtaining a copy of this software and associated documentation
-files (the "Software"), to deal in the Software without
-restriction, including without limitation the rights to use,
-copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the
-Software is furnished to do so, subject to the following
-conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
-OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
-HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
-WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
-OTHER DEALINGS IN THE SOFTWARE.
+/**
+ * Copyright (c) 2010 Werner Dittmann
+ *
+ * Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
 
-*/
+ */
 
 #ifndef SKEINAPI_H
 #define SKEINAPI_H
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] staging: skein: Add * on subsequent lines in block comment

[Amber Adams]

On 09/20/2015 11:41 PM, Greg KH wrote:
> On Sat, Sep 19, 2015 at 11:01:49PM -0500, Amber N. Adams wrote:
>> This patch fixes the checkpatch.pl warning:
>
> I don't think that the outreachy kernel application process starts until
> September 29, so we can't do anything with this patch until then :(
> 
> I'd recommend just waiting a week, or if you really want to submit this,
> send it to the mailing list that the scripts/get_maintainer.pl tool
> tells you to, and I can take it that way, but it will not count for the
> application process here, sorry.
> 
> greg k-h
> 

Thank you for the feedback, anyway! I just wanted to make sure I could
correctly submit a patch. I'll do as you suggest, then get to work on
some other patches and have them ready for Outreachy starting next week.

Amber Adams

Re: [Outreachy kernel] [PATCH] staging: skein: Add * on subsequent lines in block comment

[Greg KH]

On Sat, Sep 19, 2015 at 11:01:49PM -0500, Amber N. Adams wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: Block comments use * on subsequent lines
> +/*
> +Copyright (c) 2010 Werner Dittmann
> 
> Signed-off-by: Amber N. Adams <amber@amberadams.co>
> ---
>  drivers/staging/skein/skein_api.h | 48 +++++++++++++++++++--------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)

I don't think that the outreachy kernel application process starts until
September 29, so we can't do anything with this patch until then :(

I'd recommend just waiting a week, or if you really want to submit this,
send it to the mailing list that the scripts/get_maintainer.pl tool
tells you to, and I can take it that way, but it will not count for the
application process here, sorry.

greg k-h