From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: fix ldpc param for fixed rate
Date: Mon, 21 Sep 2015 12:53:51 +0530 [thread overview]
Message-ID: <20150921072347.GA28484@qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=FMCyHtn8BMZv_6awOuLhJNFe5RhB2eNpCQfyk+5Jhcw@mail.gmail.com>
On Mon, Sep 21, 2015 at 09:05:54AM +0200, Michal Kazior wrote:
> On 16 September 2015 at 09:49, Rajkumar Manoharan
> <rmanohar@qti.qualcomm.com> wrote:
> > ldpc is not configured for fixed rates. This blocks auto rate vs fixed
> > rate performance comparison. Since firmware is considering ldpc vdev
> > param for fixed rate selection, it has to be configured to enable ldpc
> > for fixed rates.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> > ---
> [...]
> > @@ -6041,6 +6049,7 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,
> > band = def.chan->band;
> > ht_mcs_mask = mask->control[band].ht_mcs;
> > vht_mcs_mask = mask->control[band].vht_mcs;
> > + ldpc = !!(ar->ht_cap_info & WMI_HT_CAP_LDPC);
>
> Is still really correct? LDPC must be supported on the Rx side of
> destination stations hence I would assume you need to check whether
> all stations associated are LDPC capable before enabling it (e.g. via
> ieee80211_iterate_stations_atomic).
>
I already check with firmware on this regard. Below is the clarification
got from fw team. So no need to go through sta_iter.
"3) how does fixed rate work for non-LDPC clients (ex. legacy clients),
if LDPC support is enabled for the given vdev?
The rates are selected by ANDng the vdev_rates and client rates. If client does not
support LDPC and LDPC is enabled in vdev then, LDPC will not be used."
-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix ldpc param for fixed rate
Date: Mon, 21 Sep 2015 12:53:51 +0530 [thread overview]
Message-ID: <20150921072347.GA28484@qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=FMCyHtn8BMZv_6awOuLhJNFe5RhB2eNpCQfyk+5Jhcw@mail.gmail.com>
On Mon, Sep 21, 2015 at 09:05:54AM +0200, Michal Kazior wrote:
> On 16 September 2015 at 09:49, Rajkumar Manoharan
> <rmanohar@qti.qualcomm.com> wrote:
> > ldpc is not configured for fixed rates. This blocks auto rate vs fixed
> > rate performance comparison. Since firmware is considering ldpc vdev
> > param for fixed rate selection, it has to be configured to enable ldpc
> > for fixed rates.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> > ---
> [...]
> > @@ -6041,6 +6049,7 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,
> > band = def.chan->band;
> > ht_mcs_mask = mask->control[band].ht_mcs;
> > vht_mcs_mask = mask->control[band].vht_mcs;
> > + ldpc = !!(ar->ht_cap_info & WMI_HT_CAP_LDPC);
>
> Is still really correct? LDPC must be supported on the Rx side of
> destination stations hence I would assume you need to check whether
> all stations associated are LDPC capable before enabling it (e.g. via
> ieee80211_iterate_stations_atomic).
>
I already check with firmware on this regard. Below is the clarification
got from fw team. So no need to go through sta_iter.
"3) how does fixed rate work for non-LDPC clients (ex. legacy clients),
if LDPC support is enabled for the given vdev?
The rates are selected by ANDng the vdev_rates and client rates. If client does not
support LDPC and LDPC is enabled in vdev then, LDPC will not be used."
-Rajkumar
next prev parent reply other threads:[~2015-09-21 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 7:49 [PATCH] ath10k: fix ldpc param for fixed rate Rajkumar Manoharan
2015-09-16 7:49 ` Rajkumar Manoharan
2015-09-21 7:05 ` Michal Kazior
2015-09-21 7:05 ` Michal Kazior
2015-09-21 7:23 ` Rajkumar Manoharan [this message]
2015-09-21 7:23 ` Rajkumar Manoharan
2015-09-27 12:55 ` Kalle Valo
2015-09-27 12:55 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921072347.GA28484@qca.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.