From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, riel@redhat.com, mhocko@suse.cz,
oleg@redhat.com, sasha.levin@oracle.com,
gang.chen.5i5j@gmail.com, pfeiner@google.com,
aarcange@redhat.com, vishnu.ps@samsung.com, linux-mm@kvack.org,
glider@google.com, kcc@google.com, andreyknvl@google.com,
ktsan@googlegroups.com, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] fs: fix data race on mnt.mnt_flags
Date: Mon, 21 Sep 2015 17:06:15 +0300 [thread overview]
Message-ID: <20150921140615.GA30755@node.dhcp.inet.fi> (raw)
In-Reply-To: <1442837807-70839-1-git-send-email-dvyukov@google.com>
On Mon, Sep 21, 2015 at 02:16:47PM +0200, Dmitry Vyukov wrote:
> do_remount() does:
>
> mnt_flags |= mnt->mnt.mnt_flags & ~MNT_USER_SETTABLE_MASK;
> mnt->mnt.mnt_flags = mnt_flags;
>
> This can easily be compiled as:
>
> mnt->mnt.mnt_flags &= ~MNT_USER_SETTABLE_MASK;
> mnt->mnt.mnt_flags |= mnt_flags;
>
> (also 2 memory accesses, less register pressure)
> The flags are being concurrently read by e.g. do_mmap_pgoff()
> which does:
>
> if (file->f_path.mnt->mnt_flags & MNT_NOEXEC)
>
> As the result we can allow to mmap a MNT_NOEXEC mount
> as VM_EXEC.
>
> Use WRITE_ONCE() to set new flags.
>
> The data race was found with KernelThreadSanitizer (KTSAN).
>
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, riel@redhat.com, mhocko@suse.cz,
oleg@redhat.com, sasha.levin@oracle.com,
gang.chen.5i5j@gmail.com, pfeiner@google.com,
aarcange@redhat.com, vishnu.ps@samsung.com, linux-mm@kvack.org,
glider@google.com, kcc@google.com, andreyknvl@google.com,
ktsan@googlegroups.com, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] fs: fix data race on mnt.mnt_flags
Date: Mon, 21 Sep 2015 17:06:15 +0300 [thread overview]
Message-ID: <20150921140615.GA30755@node.dhcp.inet.fi> (raw)
In-Reply-To: <1442837807-70839-1-git-send-email-dvyukov@google.com>
On Mon, Sep 21, 2015 at 02:16:47PM +0200, Dmitry Vyukov wrote:
> do_remount() does:
>
> mnt_flags |= mnt->mnt.mnt_flags & ~MNT_USER_SETTABLE_MASK;
> mnt->mnt.mnt_flags = mnt_flags;
>
> This can easily be compiled as:
>
> mnt->mnt.mnt_flags &= ~MNT_USER_SETTABLE_MASK;
> mnt->mnt.mnt_flags |= mnt_flags;
>
> (also 2 memory accesses, less register pressure)
> The flags are being concurrently read by e.g. do_mmap_pgoff()
> which does:
>
> if (file->f_path.mnt->mnt_flags & MNT_NOEXEC)
>
> As the result we can allow to mmap a MNT_NOEXEC mount
> as VM_EXEC.
>
> Use WRITE_ONCE() to set new flags.
>
> The data race was found with KernelThreadSanitizer (KTSAN).
>
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-21 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 12:16 [PATCH] fs: fix data race on mnt.mnt_flags Dmitry Vyukov
2015-09-21 12:16 ` Dmitry Vyukov
2015-09-21 14:06 ` Kirill A. Shutemov [this message]
2015-09-21 14:06 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921140615.GA30755@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktsan@googlegroups.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pfeiner@google.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishnu.ps@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.