From: Oleg Nesterov <oleg@redhat.com>
To: "Vincent Stehlé" <vincent.stehle@freescale.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
trivial@kernel.org
Subject: Re: [PATCH] fs/super.c: use && instead of & for warn_on condition
Date: Mon, 21 Sep 2015 17:40:05 +0200 [thread overview]
Message-ID: <20150921154005.GA22742@redhat.com> (raw)
In-Reply-To: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com>
On 09/21, Vincent Stehl� wrote:
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
> else
> ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
>
> - WARN_ON(force_trylock & !ret);
> + WARN_ON(force_trylock && !ret);
OOPS! yes, this is a typo, thanks! Harmless in this particular case,
but still.
Acked-by: Oleg Nesterov <oleg@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: "Vincent Stehlé" <vincent.stehle@freescale.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
trivial@kernel.org
Subject: Re: [PATCH] fs/super.c: use && instead of & for warn_on condition
Date: Mon, 21 Sep 2015 17:40:05 +0200 [thread overview]
Message-ID: <20150921154005.GA22742@redhat.com> (raw)
In-Reply-To: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com>
On 09/21, Vincent Stehlé wrote:
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
> else
> ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
>
> - WARN_ON(force_trylock & !ret);
> + WARN_ON(force_trylock && !ret);
OOPS! yes, this is a typo, thanks! Harmless in this particular case,
but still.
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2015-09-21 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 15:18 [PATCH] fs/super.c: use && instead of & for warn_on condition Vincent Stehlé
2015-09-21 15:40 ` Oleg Nesterov [this message]
2015-09-21 15:40 ` Oleg Nesterov
2015-12-08 13:51 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921154005.GA22742@redhat.com \
--to=oleg@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=vincent.stehle@freescale.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.