From: Yaowei Bai <bywxiaobai@163.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, mgorman@suse.de, rientjes@google.com,
hannes@cmpxchg.org, vdavydov@parallels.com, oleg@redhat.com,
vbabka@suse.cz, iamjoonsoo.kim@lge.com,
zhangyanfei@cn.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/vmscan: make inactive_anon_is_low_global return directly
Date: Tue, 22 Sep 2015 21:15:53 +0800 [thread overview]
Message-ID: <20150922131553.GA4221@bbox> (raw)
In-Reply-To: <20150921161806.GE19811@dhcp22.suse.cz>
On Mon, Sep 21, 2015 at 06:18:07PM +0200, Michal Hocko wrote:
> On Wed 16-09-15 19:59:58, Yaowei Bai wrote:
> > Delete unnecessary if to let inactive_anon_is_low_global return
> > directly.
> >
> > No functional changes.
>
> Is this really an improvement? I am not so sure. If anything the
> function has a bool return semantic...
Just FYI, I also sent a patch making inactive_anon_is_low_global return
bool and it has been added into Andrew's -mm tree.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Yaowei Bai <bywxiaobai@163.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, mgorman@suse.de, rientjes@google.com,
hannes@cmpxchg.org, vdavydov@parallels.com, oleg@redhat.com,
vbabka@suse.cz, iamjoonsoo.kim@lge.com,
zhangyanfei@cn.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/vmscan: make inactive_anon_is_low_global return directly
Date: Tue, 22 Sep 2015 21:15:53 +0800 [thread overview]
Message-ID: <20150922131553.GA4221@bbox> (raw)
In-Reply-To: <20150921161806.GE19811@dhcp22.suse.cz>
On Mon, Sep 21, 2015 at 06:18:07PM +0200, Michal Hocko wrote:
> On Wed 16-09-15 19:59:58, Yaowei Bai wrote:
> > Delete unnecessary if to let inactive_anon_is_low_global return
> > directly.
> >
> > No functional changes.
>
> Is this really an improvement? I am not so sure. If anything the
> function has a bool return semantic...
Just FYI, I also sent a patch making inactive_anon_is_low_global return
bool and it has been added into Andrew's -mm tree.
>
next prev parent reply other threads:[~2015-09-22 13:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 11:59 [PATCH 1/3] mm/vmscan: make inactive_anon_is_low_global return directly Yaowei Bai
2015-09-16 11:59 ` Yaowei Bai
2015-09-16 11:59 ` [PATCH 2/3] mm/oom_kill: introduce is_sysrq_oom helper Yaowei Bai
2015-09-16 11:59 ` Yaowei Bai
2015-09-21 16:18 ` Michal Hocko
2015-09-21 16:18 ` Michal Hocko
2015-09-21 23:02 ` David Rientjes
2015-09-21 23:02 ` David Rientjes
2015-09-16 12:00 ` [PATCH 3/3] mm/compaction: add an is_via_compact_memory helper function Yaowei Bai
2015-09-16 12:00 ` Yaowei Bai
2015-09-21 16:19 ` Michal Hocko
2015-09-21 16:19 ` Michal Hocko
2015-09-21 23:03 ` David Rientjes
2015-09-21 23:03 ` David Rientjes
2015-09-23 16:42 ` Vlastimil Babka
2015-09-23 16:42 ` Vlastimil Babka
2015-09-21 16:18 ` [PATCH 1/3] mm/vmscan: make inactive_anon_is_low_global return directly Michal Hocko
2015-09-21 16:18 ` Michal Hocko
2015-09-22 13:15 ` Yaowei Bai [this message]
2015-09-22 13:15 ` Yaowei Bai
2015-09-21 23:01 ` David Rientjes
2015-09-21 23:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922131553.GA4221@bbox \
--to=bywxiaobai@163.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.