All of lore.kernel.org
 help / color / mirror / Atom feed
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] power: reset: at91-shdwc: add new shutdown controller driver
Date: Tue, 22 Sep 2015 15:59:25 +0200	[thread overview]
Message-ID: <20150922135925.GI23334@earth> (raw)
In-Reply-To: <2e870dbb4c7728ad416360ff20b22c1a97ba88d9.1441881064.git.nicolas.ferre@atmel.com>

Hi,

On Thu, Sep 10, 2015 at 12:39:18PM +0200, Nicolas Ferre wrote:
> Sama5d2 SoC has a completely new shutdown controller with new
> features and register layout. It thus makes sense to add a new
> driver for this new peripheral.
> 
> This driver is Device Tree only and handles events from the
> wake-up pin and the RTC. As the register layout may change in the
> future, so some values are encoded in a configuration structure.
>
> [...]
>
> +static struct of_device_id at91_shdwc_of_match[] = {
> +	{
> +		.compatible = "atmel,sama5d2-shdwc",
> +                .data = &sama5d2_shdwc_config,
> +	}, {
> +		/*sentinel*/
> +	}
> +};

please add:

MODULE_DEVICE_TABLE(of, at91_shdwc_of_match);

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150922/8899835b/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre@kernel.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux@roeck-us.net,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 3/3] power: reset: at91-shdwc: add new shutdown controller driver
Date: Tue, 22 Sep 2015 15:59:25 +0200	[thread overview]
Message-ID: <20150922135925.GI23334@earth> (raw)
In-Reply-To: <2e870dbb4c7728ad416360ff20b22c1a97ba88d9.1441881064.git.nicolas.ferre@atmel.com>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

Hi,

On Thu, Sep 10, 2015 at 12:39:18PM +0200, Nicolas Ferre wrote:
> Sama5d2 SoC has a completely new shutdown controller with new
> features and register layout. It thus makes sense to add a new
> driver for this new peripheral.
> 
> This driver is Device Tree only and handles events from the
> wake-up pin and the RTC. As the register layout may change in the
> future, so some values are encoded in a configuration structure.
>
> [...]
>
> +static struct of_device_id at91_shdwc_of_match[] = {
> +	{
> +		.compatible = "atmel,sama5d2-shdwc",
> +                .data = &sama5d2_shdwc_config,
> +	}, {
> +		/*sentinel*/
> +	}
> +};

please add:

MODULE_DEVICE_TABLE(of, at91_shdwc_of_match);

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-09-22 13:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 10:35 [PATCH 1/3] power: reset: at91-reset/trivial: driver applies to SAMA5 family as well Nicolas Ferre
2015-09-10 10:35 ` Nicolas Ferre
2015-09-10 10:39 ` [PATCH 2/3] ARM: at91/dt: shdwc binding: add new shutdown controller documentation Nicolas Ferre
2015-09-10 10:39   ` Nicolas Ferre
2015-09-10 10:39 ` [PATCH 3/3] power: reset: at91-shdwc: add new shutdown controller driver Nicolas Ferre
2015-09-10 10:39   ` Nicolas Ferre
2015-09-22 13:59   ` Sebastian Reichel [this message]
2015-09-22 13:59     ` Sebastian Reichel
2015-09-22 15:57     ` [PATCH v2] " Nicolas Ferre
2015-09-22 15:57       ` Nicolas Ferre
2015-09-24 11:06       ` Alexandre Belloni
2015-09-24 11:06         ` Alexandre Belloni
2015-09-28  9:44         ` Nicolas Ferre
2015-09-28  9:44           ` Nicolas Ferre
2015-09-22 13:46 ` [PATCH 1/3] power: reset: at91-reset/trivial: driver applies to SAMA5 family as well Sebastian Reichel
2015-09-22 13:46   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150922135925.GI23334@earth \
    --to=sre@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.