From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Increase the max granular size
Date: Tue, 22 Sep 2015 19:29:02 +0100 [thread overview]
Message-ID: <20150922182902.GO7356@arm.com> (raw)
In-Reply-To: <1442944788-17254-1-git-send-email-rric@kernel.org>
On Tue, Sep 22, 2015 at 06:59:48PM +0100, Robert Richter wrote:
> From: Tirumalesh Chalamarla <tchalamarla@cavium.com>
>
> Increase the standard cacheline size to avoid having locks in the same
> cacheline.
>
> Cavium's ThunderX core implements cache lines of 128 byte size. With
> current granulare size of 64 bytes (L1_CACHE_SHIFT=6) two locks could
> share the same cache line leading a performance degradation.
> Increasing the size fixes that.
Do you have an example of that happening?
> Increasing the size has no negative impact to cache invalidation on
> systems with a smaller cache line. There is an impact on memory usage,
> but that's not too important for arm64 use cases.
Do you have any before/after numbers to show the impact of this change
on other supported SoCs?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Robert Richter <rric@kernel.org>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Tirumalesh Chalamarla <tchalamarla@cavium.com>,
Robert Richter <rrichter@cavium.com>
Subject: Re: [PATCH] arm64: Increase the max granular size
Date: Tue, 22 Sep 2015 19:29:02 +0100 [thread overview]
Message-ID: <20150922182902.GO7356@arm.com> (raw)
In-Reply-To: <1442944788-17254-1-git-send-email-rric@kernel.org>
On Tue, Sep 22, 2015 at 06:59:48PM +0100, Robert Richter wrote:
> From: Tirumalesh Chalamarla <tchalamarla@cavium.com>
>
> Increase the standard cacheline size to avoid having locks in the same
> cacheline.
>
> Cavium's ThunderX core implements cache lines of 128 byte size. With
> current granulare size of 64 bytes (L1_CACHE_SHIFT=6) two locks could
> share the same cache line leading a performance degradation.
> Increasing the size fixes that.
Do you have an example of that happening?
> Increasing the size has no negative impact to cache invalidation on
> systems with a smaller cache line. There is an impact on memory usage,
> but that's not too important for arm64 use cases.
Do you have any before/after numbers to show the impact of this change
on other supported SoCs?
Will
next prev parent reply other threads:[~2015-09-22 18:29 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 17:59 [PATCH] arm64: Increase the max granular size Robert Richter
2015-09-22 17:59 ` Robert Richter
2015-09-22 18:29 ` Will Deacon [this message]
2015-09-22 18:29 ` Will Deacon
2015-09-25 14:45 ` Robert Richter
2015-09-25 14:45 ` Robert Richter
2015-09-25 16:31 ` Tirumalesh Chalamarla
2015-09-25 16:31 ` Tirumalesh Chalamarla
2015-10-10 17:39 ` Timur Tabi
2015-10-10 17:39 ` Timur Tabi
2015-10-12 9:16 ` Will Deacon
2015-10-12 9:16 ` Will Deacon
2015-10-16 19:57 ` Timur Tabi
2015-10-16 19:57 ` Timur Tabi
2015-10-28 19:09 ` Catalin Marinas
2015-10-28 19:09 ` Catalin Marinas
2015-11-03 11:07 ` Geert Uytterhoeven
2015-11-03 12:05 ` Catalin Marinas
2015-11-03 12:05 ` Catalin Marinas
2015-11-03 12:05 ` Catalin Marinas
2015-11-03 14:38 ` Catalin Marinas
2015-11-03 14:38 ` Catalin Marinas
2015-11-03 14:38 ` Catalin Marinas
2015-11-03 14:55 ` Geert Uytterhoeven
2015-11-03 14:55 ` Geert Uytterhoeven
2015-11-03 14:55 ` Geert Uytterhoeven
2015-11-03 18:50 ` Catalin Marinas
2015-11-03 18:50 ` Catalin Marinas
2015-11-03 18:50 ` Catalin Marinas
2015-11-03 23:33 ` Christoph Lameter
2015-11-03 23:33 ` Christoph Lameter
2015-11-03 23:33 ` Christoph Lameter
2015-11-04 12:36 ` Catalin Marinas
2015-11-04 12:36 ` Catalin Marinas
2015-11-04 12:36 ` Catalin Marinas
2015-11-04 12:36 ` Catalin Marinas
2015-11-04 13:53 ` Christoph Lameter
2015-11-04 13:53 ` Christoph Lameter
2015-11-04 13:53 ` Christoph Lameter
2015-11-04 13:53 ` Christoph Lameter
2015-11-04 14:54 ` Catalin Marinas
2015-11-04 14:54 ` Catalin Marinas
2015-11-04 14:54 ` Catalin Marinas
2015-11-04 14:54 ` Catalin Marinas
2015-11-04 15:28 ` Christoph Lameter
2015-11-04 15:28 ` Christoph Lameter
2015-11-04 15:28 ` Christoph Lameter
2015-11-04 15:28 ` Christoph Lameter
2015-11-04 15:39 ` Catalin Marinas
2015-11-04 15:39 ` Catalin Marinas
2015-11-04 15:39 ` Catalin Marinas
2015-11-04 15:39 ` Catalin Marinas
2015-11-05 4:31 ` Joonsoo Kim
2015-11-05 4:31 ` Joonsoo Kim
2015-11-05 4:31 ` Joonsoo Kim
2015-11-05 4:31 ` Joonsoo Kim
2015-11-05 11:50 ` [PATCH] mm: slab: Only move management objects off-slab for sizes larger than KMALLOC_MIN_SIZE Catalin Marinas
2015-11-05 11:50 ` Catalin Marinas
2015-11-05 11:50 ` Catalin Marinas
2015-11-05 13:31 ` Andrew Morton
2015-11-05 13:31 ` Andrew Morton
2015-11-05 13:31 ` Andrew Morton
2015-11-05 16:08 ` Catalin Marinas
2015-11-05 16:08 ` Catalin Marinas
2015-11-05 16:08 ` Catalin Marinas
2015-11-06 13:00 ` Geert Uytterhoeven
2015-11-06 13:00 ` Geert Uytterhoeven
2015-11-06 13:00 ` Geert Uytterhoeven
2015-11-05 17:39 ` Christoph Lameter
2015-11-05 17:39 ` Christoph Lameter
2015-11-05 17:39 ` Christoph Lameter
2015-11-05 4:40 ` [PATCH] arm64: Increase the max granular size Joonsoo Kim
2015-11-05 4:40 ` Joonsoo Kim
2015-11-05 10:32 ` Catalin Marinas
2015-11-05 10:32 ` Catalin Marinas
2015-11-05 11:45 ` Joonsoo Kim
2015-11-05 11:45 ` Joonsoo Kim
2015-11-05 12:17 ` Catalin Marinas
2015-11-05 12:17 ` Catalin Marinas
2015-11-09 7:41 ` Joonsoo Kim
2015-11-09 7:41 ` Joonsoo Kim
2015-11-09 18:36 ` Catalin Marinas
2015-11-09 18:36 ` Catalin Marinas
2015-11-10 0:19 ` Joonsoo Kim
2015-11-10 0:19 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922182902.GO7356@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.