Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

[Marc Zyngier <marc.zyngier@arm.com>]

On Mon, 21 Sep 2015 10:13:04 +0800
Ley Foon Tan <lftan@altera.com> wrote:

> This patch adds the Altera PCIe host controller driver.
> 
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
> ---
>  drivers/pci/host/Kconfig       |   8 +
>  drivers/pci/host/Makefile      |   1 +
>  drivers/pci/host/pcie-altera.c | 591 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 600 insertions(+)
>  create mode 100644 drivers/pci/host/pcie-altera.c
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index d5e58ba..df9ed4f 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -145,4 +145,12 @@ config PCIE_IPROC_BCMA
>  	  Say Y here if you want to use the Broadcom iProc PCIe controller
>  	  through the BCMA bus interface
>  
> +config PCIE_ALTERA
> +	tristate "Altera PCIe controller"
> +	depends on ARCH_SOCFPGA || NIOS2
> +	select PCI_DOMAINS
> +	help
> +	  Say Y here if you want to enable PCIe controller support for Altera
> +	  SoCFPGA family of SoCs.
> +

Is there anything in this driver that is actually specific to any of
these two platforms/architectures? I'd don't think we should restrict
if we can avoid it (hint: the companion MSI driver is not restricted to
any architecture).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.