From: Sebastian Reichel <sre@kernel.org>
To: Marek Belisko <marek@goldelico.com>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org,
linux-pm@vger.kernel.org, hns@goldelico.com,
linux-kernel@vger.kernel.org, neilb@suse.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module
Date: Tue, 22 Sep 2015 23:29:38 +0200 [thread overview]
Message-ID: <20150922212900.GB15646@earth> (raw)
In-Reply-To: <1442953171-19718-1-git-send-email-marek@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hi Marek,
On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote:
> If either twl4030_charger or twl4030_madc is configured as MODULE,
> we get build (link) errors.
>
> To solve, the direct call of twl4030_get_madc_conversion() is replaced
> by a call to iio_read_channel_processed().
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> changes from V1: added missing iio_channel_release + document and add new DT bindings
That was fast :) Patchset looks fine to me except for one last
thing: Let's make the iio-channel optional, so that old DT blobs
are still supported. Also the IS_REACHABLE(CONFIG_TWL4030_MADC)
check can be removed, it should no longer be needed with
iio_read_channel_processed().
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module
Date: Tue, 22 Sep 2015 23:29:38 +0200 [thread overview]
Message-ID: <20150922212900.GB15646@earth> (raw)
In-Reply-To: <1442953171-19718-1-git-send-email-marek@goldelico.com>
Hi Marek,
On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote:
> If either twl4030_charger or twl4030_madc is configured as MODULE,
> we get build (link) errors.
>
> To solve, the direct call of twl4030_get_madc_conversion() is replaced
> by a call to iio_read_channel_processed().
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> changes from V1: added missing iio_channel_release + document and add new DT bindings
That was fast :) Patchset looks fine to me except for one last
thing: Let's make the iio-channel optional, so that old DT blobs
are still supported. Also the IS_REACHABLE(CONFIG_TWL4030_MADC)
check can be removed, it should no longer be needed with
iio_read_channel_processed().
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150922/fb16f255/attachment.sig>
next prev parent reply other threads:[~2015-09-22 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 20:19 [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module Marek Belisko
2015-09-22 20:19 ` Marek Belisko
2015-09-22 20:19 ` [PATCH v2 2/3] Documentation: DT: twl-charger: document new iio properties Marek Belisko
2015-09-22 20:19 ` Marek Belisko
2015-09-22 20:19 ` [PATCH v2 3/3] ARM: dts: twl4030: add iio properties for bci subnode Marek Belisko
2015-09-22 20:19 ` Marek Belisko
2015-09-22 21:29 ` Sebastian Reichel [this message]
2015-09-22 21:29 ` [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module Sebastian Reichel
2015-09-24 19:09 ` Belisko Marek
2015-09-24 19:09 ` Belisko Marek
2015-09-24 20:39 ` Sebastian Reichel
2015-09-24 20:39 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922212900.GB15646@earth \
--to=sre@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=hns@goldelico.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.