All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org,
	Daniel Stone <daniels@collabora.com>,
	stable@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro
Date: Wed, 23 Sep 2015 14:36:42 +0300	[thread overview]
Message-ID: <20150923113642.GY26517@intel.com> (raw)
In-Reply-To: <1442999431-28568-1-git-send-email-tvrtko.ursulin@linux.intel.com>

On Wed, Sep 23, 2015 at 10:10:31AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> __u64 should be used instead of u64.
> 
> Feature originally added in:
> 
> commit e3eb3250d84ef97b766312345774367b6a310db8
> Author: Rob Clark <robdclark@gmail.com>
> Date:   Thu Feb 5 14:41:52 2015 +0000
> 
>     drm: add support for tiled/compressed/etc modifier in addfb2
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: stable@vger.kernel.org

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  include/uapi/drm/drm_fourcc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 8c5e8b91a3cb..0b69a7753558 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -158,7 +158,7 @@
>  /* add more to the end as needed */
>  
>  #define fourcc_mod_code(vendor, val) \
> -	((((u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL))
> +	((((__u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL))
>  
>  /*
>   * Format Modifier tokens:
> -- 
> 2.5.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org,
	Daniel Stone <daniels@collabora.com>,
	stable@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro
Date: Wed, 23 Sep 2015 14:36:42 +0300	[thread overview]
Message-ID: <20150923113642.GY26517@intel.com> (raw)
In-Reply-To: <1442999431-28568-1-git-send-email-tvrtko.ursulin@linux.intel.com>

On Wed, Sep 23, 2015 at 10:10:31AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> __u64 should be used instead of u64.
> 
> Feature originally added in:
> 
> commit e3eb3250d84ef97b766312345774367b6a310db8
> Author: Rob Clark <robdclark@gmail.com>
> Date:   Thu Feb 5 14:41:52 2015 +0000
> 
>     drm: add support for tiled/compressed/etc modifier in addfb2
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: stable@vger.kernel.org

Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>

> ---
>  include/uapi/drm/drm_fourcc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 8c5e8b91a3cb..0b69a7753558 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -158,7 +158,7 @@
>  /* add more to the end as needed */
>  
>  #define fourcc_mod_code(vendor, val) \
> -	((((u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL))
> +	((((__u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL))
>  
>  /*
>   * Format Modifier tokens:
> -- 
> 2.5.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrj�l�
Intel OTC

  reply	other threads:[~2015-09-23 11:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  9:10 [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro Tvrtko Ursulin
2015-09-23  9:10 ` Tvrtko Ursulin
2015-09-23 11:36 ` Ville Syrjälä [this message]
2015-09-23 11:36   ` [Intel-gfx] " Ville Syrjälä
2015-11-05 12:51   ` Jani Nikula
2015-11-05 12:51     ` [Intel-gfx] " Jani Nikula
2015-11-05 21:12     ` Rob Clark
2015-11-05 21:12       ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150923113642.GY26517@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@intel.com \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.