From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device
Date: Wed, 23 Sep 2015 20:41:06 +0200 [thread overview]
Message-ID: <20150923184106.GA7759@lst.de> (raw)
In-Reply-To: <8BE4B1B3-54CD-46D1-9BBD-9149F6219468-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Wed, Sep 23, 2015 at 10:23:15AM -0700, Chuck Lever wrote:
> Getting rid of ib_query_device() makes sense. Moving the device
> attributes into ib_device is nice. Getting rid of ib_device_attr
> is of questionable value. Why do we need to go there?
>
> IB core API changes generate merge conflicts with feature work
> in the ULPs. It’s a pain for maintainers. In this particular
> case, keeping ib_device_attr would greatly reduce ULP churn.
But it will keep a totally nonsenical structure around in the future.
Note that the whole in-kernel Verbs API is a bit of a nightmare, so
there will be all kinds of larger changes. Better get it right as long
as we have as few ULPs as we have now.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-23 18:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 15:52 merge struct ib_device_attr into struct ib_device Christoph Hellwig
[not found] ` <1443023567-13259-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-23 15:52 ` [PATCH] IB: " Christoph Hellwig
[not found] ` <1443023567-13259-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-23 17:23 ` Chuck Lever
[not found] ` <8BE4B1B3-54CD-46D1-9BBD-9149F6219468-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-23 18:41 ` Christoph Hellwig [this message]
[not found] ` <20150923184106.GA7759-jcswGhMUV9g@public.gmane.org>
2015-09-24 5:41 ` Or Gerlitz
[not found] ` <56038CFD.8030908-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-24 6:48 ` Sagi Grimberg
[not found] ` <56039CB1.2090706-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-24 17:07 ` Weiny, Ira
2015-09-24 13:35 ` Christoph Hellwig
[not found] ` <20150924133519.GA6291-jcswGhMUV9g@public.gmane.org>
2015-10-11 16:16 ` Sagi Grimberg
[not found] ` <561A8B5B.1010309-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-11 16:24 ` Christoph Hellwig
[not found] ` <20151011162430.GA6450-jcswGhMUV9g@public.gmane.org>
2015-10-12 4:10 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2015-10-12 6:57 merge struct ib_device_attr into struct ib_device V2 Christoph Hellwig
[not found] ` <1444633078-27166-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-10-12 6:57 ` [PATCH] IB: merge struct ib_device_attr into struct ib_device Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923184106.GA7759@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.