All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	"Weiny, Ira" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device
Date: Thu, 24 Sep 2015 09:48:17 +0300	[thread overview]
Message-ID: <56039CB1.2090706@dev.mellanox.co.il> (raw)
In-Reply-To: <56038CFD.8030908-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

> Christoph,
>
> We had a smaller volume move to cache the device attributes on the IB
> device structure, and I just
> realized it was dropped on the floor. Ira, that was a reviewer comment
> you got when worked on OPA
> and I missed the fact it didn't reach to acceptance
> http://marc.info/?t=142309310600006&r=1&w=2
> I vote for 1st and most doing this and taking things from there.

That's also workable.

But Ira's patch is missing ib_query_device conversion to
simply take the cached device attributes.

I'm fine with either way to go.

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-24  6:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23 15:52 merge struct ib_device_attr into struct ib_device Christoph Hellwig
     [not found] ` <1443023567-13259-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-23 15:52   ` [PATCH] IB: " Christoph Hellwig
     [not found]     ` <1443023567-13259-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-23 17:23       ` Chuck Lever
     [not found]         ` <8BE4B1B3-54CD-46D1-9BBD-9149F6219468-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-23 18:41           ` Christoph Hellwig
     [not found]             ` <20150923184106.GA7759-jcswGhMUV9g@public.gmane.org>
2015-09-24  5:41               ` Or Gerlitz
     [not found]                 ` <56038CFD.8030908-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-24  6:48                   ` Sagi Grimberg [this message]
     [not found]                     ` <56039CB1.2090706-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-24 17:07                       ` Weiny, Ira
2015-09-24 13:35                   ` Christoph Hellwig
     [not found]                     ` <20150924133519.GA6291-jcswGhMUV9g@public.gmane.org>
2015-10-11 16:16                       ` Sagi Grimberg
     [not found]                         ` <561A8B5B.1010309-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-11 16:24                           ` Christoph Hellwig
     [not found]                             ` <20151011162430.GA6450-jcswGhMUV9g@public.gmane.org>
2015-10-12  4:10                               ` Sagi Grimberg
  -- strict thread matches above, loose matches on Subject: below --
2015-10-12  6:57 merge struct ib_device_attr into struct ib_device V2 Christoph Hellwig
     [not found] ` <1444633078-27166-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-10-12  6:57   ` [PATCH] IB: merge struct ib_device_attr into struct ib_device Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56039CB1.2090706@dev.mellanox.co.il \
    --to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.