From: Baruch Siach <baruch@tkos.co.il>
To: "Eric Bénard" <eric@eukrea.com>
Cc: linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] mxc_nand: fix copy_spare
Date: Thu, 24 Sep 2015 07:25:12 +0300 [thread overview]
Message-ID: <20150924042512.GC2229@tarshish> (raw)
In-Reply-To: <1443020848-28813-1-git-send-email-eric@eukrea.com>
Hi Eric,
On Wed, Sep 23, 2015 at 05:07:28PM +0200, Eric Bénard wrote:
> it was broken by 35d5d20efad8a04c8c002c7f31241dff973977a6
> "mtd: mxc_nand: cleanup copy_spare function"
>
> else we get the following error :
[long kernel oops resulting in:]
> Segmentation fault
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Sorry for not catching it earlier.
Thanks,
baruch
> ---
> drivers/mtd/nand/mxc_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 2426db8..f04445b 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -879,7 +879,7 @@ static void copy_spare(struct mtd_info *mtd, bool bfrom)
> oob_chunk_size);
>
> /* the last chunk */
> - memcpy16_toio(&s[oob_chunk_size * sparebuf_size],
> + memcpy16_toio(&s[i * sparebuf_size],
> &d[i * oob_chunk_size],
> host->used_oobsize - i * oob_chunk_size);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mxc_nand: fix copy_spare
Date: Thu, 24 Sep 2015 07:25:12 +0300 [thread overview]
Message-ID: <20150924042512.GC2229@tarshish> (raw)
In-Reply-To: <1443020848-28813-1-git-send-email-eric@eukrea.com>
Hi Eric,
On Wed, Sep 23, 2015 at 05:07:28PM +0200, Eric B?nard wrote:
> it was broken by 35d5d20efad8a04c8c002c7f31241dff973977a6
> "mtd: mxc_nand: cleanup copy_spare function"
>
> else we get the following error :
[long kernel oops resulting in:]
> Segmentation fault
>
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> Cc: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Sorry for not catching it earlier.
Thanks,
baruch
> ---
> drivers/mtd/nand/mxc_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 2426db8..f04445b 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -879,7 +879,7 @@ static void copy_spare(struct mtd_info *mtd, bool bfrom)
> oob_chunk_size);
>
> /* the last chunk */
> - memcpy16_toio(&s[oob_chunk_size * sparebuf_size],
> + memcpy16_toio(&s[i * sparebuf_size],
> &d[i * oob_chunk_size],
> host->used_oobsize - i * oob_chunk_size);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-09-24 4:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 15:07 [PATCH] mxc_nand: fix copy_spare Eric Bénard
2015-09-23 15:07 ` Eric Bénard
2015-09-23 18:33 ` Uwe Kleine-König
2015-09-23 18:33 ` Uwe Kleine-König
2015-09-24 4:25 ` Baruch Siach [this message]
2015-09-24 4:25 ` Baruch Siach
2015-09-28 0:21 ` Brian Norris
2015-09-28 0:21 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924042512.GC2229@tarshish \
--to=baruch@tkos.co.il \
--cc=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.