From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree@vger.kernel.org, Sunil Goutham <sgoutham@cavium.com>,
Robert Richter <rric@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
netdev@vger.kernel.org,
Soren Brinkmann <soren.brinkmann@xilinx.com>,
Iyappan Subramanian <isubramanian@apm.com>,
Grant Likely <grant.likely@linaro.org>,
Li Yang <leoli@freescale.com>, Keyur Chudgar <kchudgar@apm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes
Date: Thu, 24 Sep 2015 23:57:31 +0200 [thread overview]
Message-ID: <20150924215731.GE20825@lunn.ch> (raw)
In-Reply-To: <20150924191754.GC21513@n2100.arm.linux.org.uk>
...
> While looking at the DSA code, I noticed we have a
> of_find_net_device_by_node(), and it looks like users of that are
> similarly buggy - it looks like net/dsa/dsa.c is the only user. Fix
> that too.
...
> The mdiobus code also suffered from the same kind of leak, but thankfully
> this only happened in one place - the mdio-mux code.
Hi Russell
I tested both of these with my board. It is a Freescale Vybrid, using
the FEC ethernet driver, and i have three switches attached, using
mdio-mux to give three mdio busses.
No obvious regressions, my board boots, the switches are all present
and correct. I built the FEC driver as a module, and it won't unload:
kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1
unregister_netdevice: waiting for eth1 to become free. Usage count = 1
i assume because DSA holds a reference. I've not tried a fully module
build, DSA has issues with that.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes
Date: Thu, 24 Sep 2015 23:57:31 +0200 [thread overview]
Message-ID: <20150924215731.GE20825@lunn.ch> (raw)
In-Reply-To: <20150924191754.GC21513@n2100.arm.linux.org.uk>
...
> While looking at the DSA code, I noticed we have a
> of_find_net_device_by_node(), and it looks like users of that are
> similarly buggy - it looks like net/dsa/dsa.c is the only user. Fix
> that too.
...
> The mdiobus code also suffered from the same kind of leak, but thankfully
> this only happened in one place - the mdio-mux code.
Hi Russell
I tested both of these with my board. It is a Freescale Vybrid, using
the FEC ethernet driver, and i have three switches attached, using
mdio-mux to give three mdio busses.
No obvious regressions, my board boots, the switches are all present
and correct. I built the FEC driver as a module, and it won't unload:
kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1
unregister_netdevice: waiting for eth1 to become free. Usage count = 1
i assume because DSA holds a reference. I've not tried a fully module
build, DSA has issues with that.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
next prev parent reply other threads:[~2015-09-24 22:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 19:17 [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes Russell King - ARM Linux
2015-09-24 19:17 ` Russell King - ARM Linux
2015-09-24 19:17 ` Russell King - ARM Linux
2015-09-24 19:18 ` [PATCH 1/9] phy: fix of_mdio_find_bus() device refcount leak Russell King
2015-09-24 19:18 ` [PATCH 2/9] net: dsa: " Russell King
2015-09-24 19:18 ` [PATCH 3/9] phy: fix mdiobus module safety Russell King
2015-09-24 19:18 ` [PATCH 4/9] phy: add proper phy struct device refcounting Russell King
2015-09-24 19:18 ` [PATCH 5/9] of_mdio: fix MDIO phy " Russell King
2015-09-24 22:20 ` Rob Herring
2015-09-24 19:18 ` [PATCH 6/9] net: fix phy refcounting in a bunch of drivers Russell King
2015-09-24 19:18 ` Russell King
2015-09-24 19:18 ` Russell King
2015-09-24 19:18 ` [PATCH 7/9] phy: fixed-phy: properly validate phy in fixed_phy_update_state() Russell King
2015-09-24 19:18 ` [PATCH 8/9] phy: add phy_device_remove() Russell King
2015-09-24 19:19 ` [PATCH 9/9] net: fix net_device refcounting Russell King
2015-09-24 21:57 ` Andrew Lunn [this message]
2015-09-24 21:57 ` [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes Andrew Lunn
2015-09-24 22:15 ` Russell King - ARM Linux
2015-09-24 22:15 ` Russell King - ARM Linux
2015-09-24 22:50 ` Andrew Lunn
2015-09-24 22:50 ` Andrew Lunn
2015-09-24 22:50 ` Andrew Lunn
2015-09-24 23:33 ` Russell King - ARM Linux
2015-09-24 23:33 ` Russell King - ARM Linux
2015-09-24 22:15 ` David Miller
2015-09-24 22:15 ` David Miller
2015-09-24 22:26 ` Andrew Lunn
2015-09-24 22:26 ` Andrew Lunn
2015-09-24 22:26 ` Andrew Lunn
2015-09-24 22:51 ` David Miller
2015-09-24 22:51 ` David Miller
2015-09-24 22:51 ` David Miller
2015-09-24 23:12 ` Russell King - ARM Linux
2015-09-24 23:12 ` Russell King - ARM Linux
2015-09-25 1:39 ` Florian Fainelli
2015-09-25 1:39 ` Florian Fainelli
2015-09-25 6:05 ` David Miller
2015-09-25 6:05 ` David Miller
2015-09-25 6:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924215731.GE20825@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=leoli@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=soren.brinkmann@xilinx.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.