From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-doc@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging
Date: Fri, 25 Sep 2015 13:54:06 +0000 [thread overview]
Message-ID: <20150925134206.GA4799@sudip-pc> (raw)
In-Reply-To: <5603E567.5000001@ti.com>
On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote:
>
> On 02/09/15 15:48, Sudip Mukherjee wrote:
>
<snip>
>
> Is there a public datasheet for the HW?
I could not find one in Silicon Motion website. I will try to find else
I can talk to them and keep it in my github. And can send you also if
you want.
>
> The driver as it is now is quite horrible. Huge tables of raw data,
> written directly to the registers. Lots of magic numbers all around.
> Even with a datasheet, presuming it's public and it contains all those
> values, the driver is rather unmaintainable.
>
> All those need to be sorted out for the DRM driver anyway, so maybe it's
> better to clean up the fb driver first.
Ok. I never looked at them to see how they can be made better. I will
see.
regards
sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-doc@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging
Date: Fri, 25 Sep 2015 19:12:06 +0530 [thread overview]
Message-ID: <20150925134206.GA4799@sudip-pc> (raw)
In-Reply-To: <5603E567.5000001@ti.com>
On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote:
>
> On 02/09/15 15:48, Sudip Mukherjee wrote:
>
<snip>
>
> Is there a public datasheet for the HW?
I could not find one in Silicon Motion website. I will try to find else
I can talk to them and keep it in my github. And can send you also if
you want.
>
> The driver as it is now is quite horrible. Huge tables of raw data,
> written directly to the registers. Lots of magic numbers all around.
> Even with a datasheet, presuming it's public and it contains all those
> values, the driver is rather unmaintainable.
>
> All those need to be sorted out for the DRM driver anyway, so maybe it's
> better to clean up the fb driver first.
Ok. I never looked at them to see how they can be made better. I will
see.
regards
sudip
next prev parent reply other threads:[~2015-09-25 13:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 4:08 [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging Sudip Mukherjee
2015-07-18 4:08 ` [PATCH v2 2/3] Documentation/fb: add documentation for sm712fb Sudip Mukherjee
2015-07-18 4:20 ` Sudip Mukherjee
2015-07-18 4:08 ` [PATCH v2 3/3] MAINTAINERS: update maintainers list Sudip Mukherjee
2015-07-18 4:20 ` Sudip Mukherjee
2015-07-27 4:53 ` [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging Sudip Mukherjee
2015-07-27 4:53 ` Sudip Mukherjee
2015-09-01 13:27 ` Tomi Valkeinen
2015-09-01 13:27 ` Tomi Valkeinen
2015-09-01 13:55 ` Sudip Mukherjee
2015-09-01 13:55 ` Sudip Mukherjee
2015-09-02 11:58 ` Tomi Valkeinen
2015-09-02 11:58 ` Tomi Valkeinen
2015-09-02 12:48 ` Sudip Mukherjee
2015-09-02 12:48 ` Sudip Mukherjee
2015-09-24 11:58 ` Tomi Valkeinen
2015-09-24 11:58 ` Tomi Valkeinen
2015-09-25 13:42 ` Sudip Mukherjee [this message]
2015-09-25 13:54 ` Sudip Mukherjee
2015-09-27 4:42 ` Mike Rapoport
2015-09-27 4:42 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925134206.GA4799@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.