From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org,
jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com,
wangnan0@huawei.com, pi3orama@163.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms of hw/sw events
Date: Sun, 27 Sep 2015 22:27:15 +0200 [thread overview]
Message-ID: <20150927202715.GE24007@krava.redhat.com> (raw)
In-Reply-To: <1443179511-59238-2-git-send-email-hekuang@huawei.com>
On Fri, Sep 25, 2015 at 11:11:49AM +0000, He Kuang wrote:
> Prompt proper error message when wrong config terms is specificed for
> hw/sw type perf events. This patch makes the original error prompt
> function formats_error_string() more generic, which only outputs the
> static config terms for hw/sw perf events, and prepends pmu formats
> for pmu events.
>
> Before this patch:
>
> $ perf record -e 'cpu-clock/freq=200/' -a sleep 1
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.028 MB perf.data (202 samples) ]
>
> $ perf record -e 'cpu-clock/freqx=200/' -a sleep 1
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.042 MB perf.data (506 samples) ]
this output is not correct at this version,
patch 1/4 will make the above command fail
please change the example accordingly
jirka
next prev parent reply other threads:[~2015-09-27 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 11:11 [PATCH v2 1/4] perf tools: Adds the config_term callback for different type events He Kuang
2015-09-25 11:11 ` [PATCH v2 2/4] perf tools: Prompt error message for wrong terms of hw/sw events He Kuang
2015-09-27 20:27 ` Jiri Olsa [this message]
2015-09-27 20:28 ` Jiri Olsa
2015-09-27 20:30 ` Jiri Olsa
2015-09-25 11:11 ` [PATCH v2 3/4] perf tools: Adds the tracepoint name parsing support He Kuang
2015-09-27 20:33 ` Jiri Olsa
2015-09-27 20:34 ` Jiri Olsa
2015-09-25 11:11 ` [PATCH v2 4/4] perf tools: Enable event_config terms to tracepoint events He Kuang
2015-09-27 20:41 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927202715.GE24007@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.