From: Alexandru Moise <00moses.alexander00@gmail.com>
To: akpm@linux-foundation.org
Cc: vdavydov@parallels.com, mhocko@suse.cz, hannes@cmpxchg.org,
tj@kernel.org, vbabka@suse.cz, mgorman@suse.de,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable
Date: Sun, 27 Sep 2015 21:04:25 +0000 [thread overview]
Message-ID: <20150927210425.GA20155@gmail.com> (raw)
The nr variable is meant to be returned by a function which is
declared as returning "unsigned long", so declare nr as such.
Lower down we should also declare delta and nr_pagecache_reclaimable
as being unsigned longs because they're used to store the values
returned by zone_page_state() and zone_unmapped_file_pages() which
also happen to return unsigned integers.
Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
---
mm/vmscan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 7f63a93..41e254e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
static unsigned long zone_reclaimable_pages(struct zone *zone)
{
- int nr;
+ unsigned long nr;
nr = zone_page_state(zone, NR_ACTIVE_FILE) +
zone_page_state(zone, NR_INACTIVE_FILE);
@@ -3698,8 +3698,8 @@ static inline unsigned long zone_unmapped_file_pages(struct zone *zone)
/* Work out how many page cache pages we can reclaim in this reclaim_mode */
static long zone_pagecache_reclaimable(struct zone *zone)
{
- long nr_pagecache_reclaimable;
- long delta = 0;
+ unsigned long nr_pagecache_reclaimable;
+ unsigned long delta = 0;
/*
* If RECLAIM_UNMAP is set, then all file pages are considered
--
2.5.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Moise <00moses.alexander00@gmail.com>
To: akpm@linux-foundation.org
Cc: vdavydov@parallels.com, mhocko@suse.cz, hannes@cmpxchg.org,
tj@kernel.org, vbabka@suse.cz, mgorman@suse.de,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable
Date: Sun, 27 Sep 2015 21:04:25 +0000 [thread overview]
Message-ID: <20150927210425.GA20155@gmail.com> (raw)
The nr variable is meant to be returned by a function which is
declared as returning "unsigned long", so declare nr as such.
Lower down we should also declare delta and nr_pagecache_reclaimable
as being unsigned longs because they're used to store the values
returned by zone_page_state() and zone_unmapped_file_pages() which
also happen to return unsigned integers.
Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
---
mm/vmscan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 7f63a93..41e254e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
static unsigned long zone_reclaimable_pages(struct zone *zone)
{
- int nr;
+ unsigned long nr;
nr = zone_page_state(zone, NR_ACTIVE_FILE) +
zone_page_state(zone, NR_INACTIVE_FILE);
@@ -3698,8 +3698,8 @@ static inline unsigned long zone_unmapped_file_pages(struct zone *zone)
/* Work out how many page cache pages we can reclaim in this reclaim_mode */
static long zone_pagecache_reclaimable(struct zone *zone)
{
- long nr_pagecache_reclaimable;
- long delta = 0;
+ unsigned long nr_pagecache_reclaimable;
+ unsigned long delta = 0;
/*
* If RECLAIM_UNMAP is set, then all file pages are considered
--
2.5.3
next reply other threads:[~2015-09-27 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 21:04 Alexandru Moise [this message]
2015-09-27 21:04 ` [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable Alexandru Moise
2015-09-29 23:07 ` Andrew Morton
2015-09-29 23:07 ` Andrew Morton
2015-09-30 5:10 ` Alexandru Moise
2015-09-30 5:10 ` Alexandru Moise
2015-09-30 5:28 ` Andrew Morton
2015-09-30 5:28 ` Andrew Morton
2015-09-30 5:33 ` Alexandru Moise
2015-09-30 5:33 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927210425.GA20155@gmail.com \
--to=00moses.alexander00@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.