From: kbuild test robot <lkp@intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
nicolas.ferre@atmel.com, Liam Girdwood <lgirdwood@gmail.com>,
broonie@kernel.org, kbuild-all@01.org,
Songjun Wu <songjun.wu@atmel.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings
Date: Mon, 28 Sep 2015 17:10:29 +0800 [thread overview]
Message-ID: <20150928091029.GA23312@roam> (raw)
In-Reply-To: <1443417278-19657-2-git-send-email-songjun.wu@atmel.com>
sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Songjun Wu <songjun.wu@atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
atmel-classd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
dd->gclk = devm_clk_get(dev, "gclk");
if (IS_ERR(dd->aclk)) {
- ret = PTR_ERR(dd->gclk);
+ ret = PTR_ERR(dd->aclk);
dev_err(dev, "failed to get GCK clock: %d\n", ret);
return ret;
}
WARNING: multiple messages have this Message-ID (diff)
From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings
Date: Mon, 28 Sep 2015 17:10:29 +0800 [thread overview]
Message-ID: <20150928091029.GA23312@roam> (raw)
In-Reply-To: <1443417278-19657-2-git-send-email-songjun.wu@atmel.com>
sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Songjun Wu <songjun.wu@atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
atmel-classd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
dd->gclk = devm_clk_get(dev, "gclk");
if (IS_ERR(dd->aclk)) {
- ret = PTR_ERR(dd->gclk);
+ ret = PTR_ERR(dd->aclk);
dev_err(dev, "failed to get GCK clock: %d\n", ret);
return ret;
}
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Songjun Wu <songjun.wu@atmel.com>
Cc: kbuild-all@01.org, linux-arm-kernel@lists.infradead.org,
broonie@kernel.org, nicolas.ferre@atmel.com,
Songjun Wu <songjun.wu@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings
Date: Mon, 28 Sep 2015 17:10:29 +0800 [thread overview]
Message-ID: <20150928091029.GA23312@roam> (raw)
In-Reply-To: <1443417278-19657-2-git-send-email-songjun.wu@atmel.com>
sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Songjun Wu <songjun.wu@atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
atmel-classd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
dd->gclk = devm_clk_get(dev, "gclk");
if (IS_ERR(dd->aclk)) {
- ret = PTR_ERR(dd->gclk);
+ ret = PTR_ERR(dd->aclk);
dev_err(dev, "failed to get GCK clock: %d\n", ret);
return ret;
}
next prev parent reply other threads:[~2015-09-28 9:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 5:14 [RESEND PATCH v2 0/2] ASoC: atmel-classd: add driver for Atmel CLASSD Songjun Wu
2015-09-28 5:14 ` Songjun Wu
2015-09-28 5:14 ` Songjun Wu
2015-09-28 5:14 ` [RESEND PATCH v2 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu
2015-09-28 5:14 ` Songjun Wu
2015-09-28 5:14 ` Songjun Wu
2015-09-28 9:10 ` [PATCH] ASoC: atmel-classd: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-09-28 9:10 ` kbuild test robot
2015-09-28 9:10 ` kbuild test robot
2015-09-28 9:10 ` kbuild test robot [this message]
2015-09-28 9:10 ` [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings kbuild test robot
2015-09-28 9:10 ` kbuild test robot
2015-09-28 11:26 ` [alsa-devel] " Peter Korsgaard
2015-09-28 11:26 ` Peter Korsgaard
2015-09-29 1:42 ` Wu, Songjun
2015-09-29 1:42 ` Wu, Songjun
2015-09-29 1:42 ` Wu, Songjun
2015-09-28 5:14 ` [RESEND PATCH v2 2/2] SoC: atmel-classd: DT binding for Class D audio amplifier driver Songjun Wu
2015-09-28 5:14 ` Songjun Wu
2015-09-28 5:14 ` Songjun Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928091029.GA23312@roam \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kbuild-all@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=songjun.wu@atmel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.