From: Lee Jones <lee.jones@linaro.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCHv3 2/3] backlight: add led-backlight driver
Date: Mon, 28 Sep 2015 10:31:54 +0000 [thread overview]
Message-ID: <20150928103154.GO27197@x1> (raw)
In-Reply-To: <5608F66E.8020703@ti.com>
On Mon, 28 Sep 2015, Tomi Valkeinen wrote:
> > This patch adds a led-backlight driver (led_bl), which is similar to
> > pwm_bl except the driver uses a LED class driver to adjust the
> > brightness in the HW.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > drivers/video/backlight/Kconfig | 7 ++
> > drivers/video/backlight/Makefile | 1 +
> > drivers/video/backlight/led_bl.c | 246 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 254 insertions(+)
> > create mode 100644 drivers/video/backlight/led_bl.c
>
> Any comments on the backlight side of this series? It is very similar to
> the pwm_bl.c, so I presume the approach is acceptable?
Jingoo?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCHv3 2/3] backlight: add led-backlight driver
Date: Mon, 28 Sep 2015 11:31:54 +0100 [thread overview]
Message-ID: <20150928103154.GO27197@x1> (raw)
In-Reply-To: <5608F66E.8020703@ti.com>
On Mon, 28 Sep 2015, Tomi Valkeinen wrote:
> > This patch adds a led-backlight driver (led_bl), which is similar to
> > pwm_bl except the driver uses a LED class driver to adjust the
> > brightness in the HW.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > drivers/video/backlight/Kconfig | 7 ++
> > drivers/video/backlight/Makefile | 1 +
> > drivers/video/backlight/led_bl.c | 246 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 254 insertions(+)
> > create mode 100644 drivers/video/backlight/led_bl.c
>
> Any comments on the backlight side of this series? It is very similar to
> the pwm_bl.c, so I presume the approach is acceptable?
Jingoo?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-09-28 10:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 13:07 [PATCHv3 0/3] backlight: led-backlight driver Tomi Valkeinen
2015-09-11 13:07 ` Tomi Valkeinen
2015-09-11 13:07 ` [PATCHv3 1/3] leds: Add of_led_get() and led_put() Tomi Valkeinen
2015-09-11 13:07 ` Tomi Valkeinen
2015-09-11 13:50 ` Jacek Anaszewski
2015-09-11 13:50 ` Jacek Anaszewski
2015-09-28 8:08 ` Tomi Valkeinen
2015-09-28 8:08 ` Tomi Valkeinen
2015-09-11 13:07 ` [PATCHv3 2/3] backlight: add led-backlight driver Tomi Valkeinen
2015-09-11 13:07 ` Tomi Valkeinen
2015-09-28 8:12 ` Tomi Valkeinen
2015-09-28 8:12 ` Tomi Valkeinen
2015-09-28 10:31 ` Lee Jones [this message]
2015-09-28 10:31 ` Lee Jones
2015-09-11 13:07 ` [PATCHv3 3/3] devicetree: Add led-backlight binding Tomi Valkeinen
2015-09-11 13:07 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928103154.GO27197@x1 \
--to=lee.jones@linaro.org \
--cc=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.